Repository navigation
Conversation
flush_done_attention stopped at the first end-of-message. SQL Server 2022 ends a batch cancelled before it returned anything with a DONE_ERROR message and sends the DONE_ATTN acknowledgement as the next message, so cancel_query failed with "Never got a DONE token acknowledging the Attention signal." and the next request read the acknowledgement.
datlechin
added a commit
to TableProApp/TablePro
that referenced
this pull request
Oct 13, 2026
…s#459 tiberius 0.13 drops a connection whose attention lands while the server is still waiting. The fix is tiberius-rs/tiberius#460.
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459.
flush_done_attentionreads past end-of-message until a DONE, DONEPROC or DONEINPROC with DONE_ATTN arrives, and discards everything before it, ERROR tokens included.try_unfoldkeeps its behavior. It now calls a privateunfold(stop_at_end_of_message), which the attention drain calls withfalse.UnexpectedEof.command_timeoutstill bounds each read.tds::stream::token: the ack in the next message, the next request reading its own response after a cancel, and transport EOF before the ack.cancel_query_after_dropping_a_running_query(tokio and smol): drops a runningWAITFOR DELAY '00:00:30'after 300 ms, cancels, then runsSELECT 1.Against
mcr.microsoft.com/mssql/server:2022-CU14-ubuntu-22.04:cancel_queryreturnsErr(Protocol("Never got a DONE token acknowledging the Attention signal."))and the nextSELECT 1returns no rowcancel_queryreturnsOkin 1 to 2 ms andSELECT 1returns 1