fix: mark compacted memory injection part as synthetic - #248
Merged
lindixu6-hash merged 1 commit intoAug 19, 2026
Conversation
The compaction restore injected the memory dump as a normal text part, so it was echoed into the live session transcript. Mark the part synthetic so the TUI does not render it. Follow-up to tickernelz#239, which preserved the session agent on compaction restore but did not mark the injected part synthetic.
lindixu6-hash
approved these changes
Aug 17, 2026
lindixu6-hash
left a comment
lindixu6-hash
left a comment
Collaborator
There was a problem hiding this comment.
Verified at 30374c3. The change follows the existing synthetic-part convention used by chat.message injection, and the new regression is failure-sensitive.
Local verification with an isolated HOME:
- frozen root and web installs
- compaction target: 9/9 passed
- full suite after build: 408/408 passed
- typecheck, Prettier check, and production build passed
- mutation check: reverting only the implementation while retaining the test produced the expected 1 failure (synthetic was undefined)
The scope is small and preserves the existing agent/noReply behavior.
Collaborator
|
Post-merge validation for exact merge commit |
This was referenced Aug 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compaction restore injected the memory dump as a normal text part, so it was echoed into the live session transcript. Mark the part synthetic so the TUI does not render it.
Follow-up to #239, which preserved the session agent on compaction restore but did not mark the injected part synthetic.