Skip to content

Require m >= 1 in mase() - #644

Open
taekop wants to merge 1 commit into
tidymodels:mainfrom
taekop:fix/mase-m-zero
Open

taekop wants to merge 1 commit into
tidymodels:mainfrom
taekop:fix/mase-m-zero

Conversation

@taekop

@taekop taekop commented Sep 26, 2026

Copy link
Copy Markdown

mase() checked the seasonal period with check_number_whole(m, min = 0), so m = 0 returned Inf/NaN instead of an error. This changes the bound to min = 1 and adds a snapshot test.

Fixes #637

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mase() silently accepts m = 0 and returns NaN

1 participant