Fix collection items colliding when they share a basename#783
Merged
Conversation
1c19ce6 to
63f3f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #674
Issue
Two files in the same collection with the same basename (e.g.
_posts/example.mdand_posts/foo/example.md) would silently collapse into a single output. The collection is keyed bygetFilename(), so the second item overwrites the first.Solution
Items are now keyed by
relativePath/filenamewhen nested. the new methoditemKeyencapsulates the logic. User-facing access by basename ($siteData->posts->{name}) is unchanged for flat collections. For nested collections, two items that previously masked each other are now both reachable.