feat(web): add per-container log filtering to the log pane#6763
Open
breezy-devs wants to merge 2 commits into
Open
feat(web): add per-container log filtering to the log pane#6763breezy-devs wants to merge 2 commits into
breezy-devs wants to merge 2 commits into
Conversation
Adds a structured `container` field to every log line emitted by the pod log streaming controller, using the existing logger.Fields mechanism. This lets the frontend filter logs by container without parsing log text. Signed-off-by: Brent Hiranaka <brenthiranaka95@gmail.com>
7edc4b4 to
4c8e85e
Compare
efc73da to
f7bb2a4
Compare
0566c1b to
68fa027
Compare
Adds a container filter dropdown to the action bar when a resource has logs from 2 or more distinct containers. Selection is URL-persisted via the existing search param pattern and integrates with the existing FilterSet and log display pipeline. Signed-off-by: Brent Hiranaka <brenthiranaka95@gmail.com>
68fa027 to
fa84275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3814
Summary
containerstructured field to every pod log line in the streaming controller, enabling frontend filtering without text parsinglocal_resource) never render the dropdownFilterSetpipelineMulti-Container
Single Container
No container
Test plan
go test ./internal/controllers/core/podlogstream/...to verify the newTestLogContainerFieldtest passesyarn testinweb/to verify all frontend tests passlocal_resource) shows no dropdown