fix: down-policy not respected when resource is disabled via UI#6767
Open
Abzaek wants to merge 1 commit into
Open
fix: down-policy not respected when resource is disabled via UI#6767Abzaek wants to merge 1 commit into
Abzaek wants to merge 1 commit into
Conversation
When a Kubernetes resource is disabled through the Tilt UI, the garbageCollect() method deletes its dangling objects without checking tilt.dev/down-policy. This causes resources with down-policy: keep to be deleted despite the annotation. Fix: skip dangling objects that have tilt.dev/down-policy: keep during garbage collection. Fixes tilt-dev#6645 Signed-off-by: Abdulazez A. <abzaeko@gmail.com>
Abzaek
force-pushed
the
fix/down-policy-disabled-resources
branch
from
4d0f7b9 to
f313129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Kubernetes resource has tilt.dev/down-policy: keep and is disabled through the Tilt UI, the resource gets deleted anyway.
Root Cause
tilt down (in internal/cli/down.go) correctly checks for the down-policy annotation. However, when a resource is disabled via the Tilt UI, the KubernetesApply reconciler garbageCollect() method deletes dangling objects without checking for the annotation.
Fix
In garbageCollect(), skip objects with tilt.dev/down-policy: keep before appending to the delete list. This ensures the annotation is respected during both tilt down and resource disable/delete operations.
Fixes #6645