add to_primitive for OffsetDateTime#771
Closed
PacificBird wants to merge 1 commit intotime-rs:mainfrom
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
- Coverage 94.2% 94.0% -0.2%
=======================================
Files 96 97 +1
Lines 10732 11139 +407
=======================================
+ Hits 10107 10473 +366
- Misses 625 666 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with my legacy database at work while trying to have a sensible internal API for dealing with times I need to downcast
OffsetDateTimes toPrimitiveDateTimes constantly. I was very surprised to find this isn't built-in since it is simple but needlessly verbose to achieve with the existing API. I cannot express how much nicer my code will become with this method available. Being able to go from wrapping it in a free function to a method call would be lovely.