Skip to content

fix(connections): reflect install progress/state on skill & MCP cards#4224

Open
M3gA-Mind wants to merge 1 commit into
tinyhumansai:mainfrom
M3gA-Mind:fix/connections-install-button-state-4150
Open

fix(connections): reflect install progress/state on skill & MCP cards#4224
M3gA-Mind wants to merge 1 commit into
tinyhumansai:mainfrom
M3gA-Mind:fix/connections-install-button-state-4150

Conversation

@M3gA-Mind

Copy link
Copy Markdown
Collaborator

On Connections → Skills, clicking Install on a catalog card showed "Installing…" + a toast, but the card then reverted to "Install": whether it flipped to "Installed" depended entirely on isCatalogEntryInstalled, a heuristic that re-maps the refetched installed list back to the catalog entry by slugified id/path. When a registry skill's post-install id/location doesn't map back, the match misses and the only signal of success was a fleeting toast — exactly the reported "toast appears, card unchanged, no persistent state."

Fix: track the entry ids installed this session and treat a card as installed if it's in that set OR the heuristic matches, so a successful install deterministically flips the card to "Installed" and keeps it there. The MCP servers tab already reflected state correctly (install dialog sets installing → onSuccess → loadInstalled → catalog filters out installed servers); this closes the gap on the skill cards. Adds a regression test where install succeeds while the refetched list does not map back.

Closes #4150

On Connections → Skills, clicking Install on a catalog card showed "Installing…"
and a toast, but the card then reverted to "Install": whether it flipped to
"Installed" depended entirely on `isCatalogEntryInstalled`, a heuristic that
re-maps the refetched installed list back to the catalog entry by slugified
id/path. When a registry skill's post-install id/location doesn't map back, the
match misses and the only signal of success was a fleeting toast — exactly the
reported "toast appears, card unchanged, no persistent state" (tinyhumansai#4150).

Track the ids we install this session (`installedEntryIds`) and treat a card as
installed if it's in that set OR the heuristic matches, so a successful install
deterministically flips the card to "Installed" and keeps it there. The MCP
servers tab already reflected state correctly (install dialog → loadInstalled →
catalog filters out installed servers); this closes the gap on the skill cards.
Adds a regression test: install succeeds while the refetched list does not map
back, card still shows "Installed".

Closes tinyhumansai#4150
@M3gA-Mind M3gA-Mind requested a review from a team June 26, 2026 16:56
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@M3gA-Mind, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 29 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a11a228f-27a2-4a13-9ac5-f8dc5a71d4a7

📥 Commits

Reviewing files that changed from the base of the PR and between 56af7ec and 57a7f79.

📒 Files selected for processing (2)
  • app/src/components/skills/SkillsExplorerTab.tsx
  • app/src/components/skills/__tests__/SkillsExplorerTab.test.tsx

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: clicking Install on a skill/card only shows a toast — no install state change or progress indication

1 participant