fix(observability): demote skill install 4xx fetches#4238
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughSkill install fetch failures with 4xx HTTP status codes are now suppressed from Sentry reporting. A helper gates fetch-status observability in Skill install 4xx Sentry suppression
Documentation link update
ChangesSkill install 4xx Sentry suppression
Documentation link update
Sequence Diagram(s)sequenceDiagram
participant ops_install
participant observability
participant tests
ops_install->>ops_install: should_report_install_fetch_status(status)
alt status is 5xx or non-client error
ops_install->>observability: report_error(domain=skills, operation=install_fetch)
else status is 2xx or 4xx
ops_install->>ops_install: debug log, skip report
end
tests->>ops_install: assert helper behavior
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- ops_install.rs: keep this PR's should_report_install_fetch_status helper + debug breadcrumb at the SKILL.md fetch emit site (functionally equivalent to main's inline !is_client_error() from tinyhumansai#4188, but the helper is re-exported, reused by this PR's tests, and pairs with the new before_send guard). Preserved main's TAURI-RUST-CGE rationale comment. - docs/README.*.md (de/ja-JP/ko/ur-pk/zh-CN): take main's already-merged link fixes (Discussions link, canonical star-history) — this PR carried the same fixes from tinyhumansai#4237, now superseded on main.
Summary
SKILL.mdfetch 4xx responses from skill install to Sentry.before_sendfilter forskills.install_fetch4xx events in both core and Tauri entrypoints.Problem
SKILL.mdfetch failure to Sentry.Solution
should_report_install_fetch_statusso skill install reports only non-success, non-client-error HTTP statuses.is_skill_install_user_fetch_failureas a Sentry event-shape guard for any existing or futureskills.install_fetch4xx event.before_sendchains.Submission Checklist
## Related— N/A: no coverage-matrix feature ID applies.docs/RELEASE-MANUAL-SMOKE.md) — N/A: observability filtering only.Closes #NNNin the## RelatedsectionImpact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/GH-4175-skill-install-4xxd41c8a6903f7bb6dc739528434f8dd3486df025bValidation Run
pnpm --filter openhuman-app format:check— N/A: no app TS/CSS changes.pnpm typecheck— N/A: no frontend TypeScript changes.GGML_NATIVE=OFF cargo test --manifest-path Cargo.toml --lib install_fetch_status_reporting_suppresses_client_errors_onlyGGML_NATIVE=OFF cargo test --manifest-path Cargo.toml --lib skills_install_fetch_filterGGML_NATIVE=OFF cargo test --manifest-path Cargo.toml --test observability_smoke skills_installGGML_NATIVE=OFF cargo test --manifest-path Cargo.toml --lib install_workflow_from_urlcargo fmt --manifest-path Cargo.toml --checkgit diff --checkGGML_NATIVE=OFF cargo check --manifest-path Cargo.tomlcargo fmt --manifest-path app/src-tauri/Cargo.toml --checkGGML_NATIVE=OFF cargo check --manifest-path app/src-tauri/Cargo.tomlValidation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit
Bug Fixes
Tests
Documentation