Protocol 3.17#44
Open
bennypowers wants to merge 5 commits into
Open
Conversation
Assisted-By: claude
Add workspace/diagnostic request handler and types per LSP 3.17 spec,
enabling pull-based workspace-wide diagnostics. Fix copy-paste bug in
ImplementationRegistrationOptions embedding, MarkedString.UnmarshalJSON
value receiver, SemanticTokensClientCapabilities JSON tag casing, and
a typo in notebook-document.go. Replace interface{} with any, add nil
guards in tests, and replace no-op test assertions with real checks.
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix BoolOrString.UnmarshalJSON value receiver so parsed values are retained. Make BoolOrString.String() safe when Value is nil. Use discriminator fields for polymorphic JSON unmarshaling in TextDocumentEdit (annotationId), WorkspaceEdit (kind), and CompletionItem (insert). Handle embedded WorkDoneProgressOptions in SemanticTokensOptions.UnmarshalJSON. Handle explicit JSON null for TextDocumentSyncOptions save field. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merge inlay hint support from dschmidt. Our branch already had a more complete inlay hint implementation including InlayHintLabelPart, InlayHintResolve, and client capabilities, so we keep our version and remove the duplicate inlay-hints.go file. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Caution
This PR was prepared using an LLM code assistant. Please carefully review it.