Open
Conversation
As of now, having a type named "Result" in the same scope as the impl_context! macro invocation result in a failure. This test reproduces the behavior. The test passes if it compiles.
Clarify the reference to the type result by explicitly referring to core::result::Result. This avoids conflicts if there is a non-default Result type. Using core::result::Result over std::result::Result to keep minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Maintainer,
if there is a type called
Resultin the same scope as the macro invocation toimpl_context!, the compilation fails as of now (with a rather cryptic error):This PR (1) adds a test case for this, and (2) fixes it by referring to
core::result::Resultinstead of onlyResult.This is my first time working with macros, and I just followed my gut with the fix. It works, but if it goes against best practices please let me know.