Fix progress bar estimation for FT Jobs #415
Open
+11
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes time estimations for the Finetuning jobs. Instead of using update_at timestamp, it uses started_at timestamp. The new timestamp indicates when the current stage of the training job has started.
Note
Switches progress/ETA calculations to the job
started_attimestamp for accuracy.generate_progress_barto gate on and derive elapsed time fromstarted_at(with timezone-safe parsing) instead ofupdated_atFinetuneResponsewithstarted_atand wire it into progress logicstarted_at, adjust assertions (including timezone, future-start, and rich formatting cases)Written by Cursor Bugbot for commit 101aefc. This will update automatically on new commits. Configure here.