Repository navigation
Fix repeated SourceFd readiness with the poll selector - #2020
Closed
akasakariko wants to merge 1 commit into
Closed
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
Author
|
@Thomasdezeeuw Could you share why this was closed? I'd like to know whether the approach is wrong or you'd prefer a different fix |
Collaborator
|
I'm not going to review an AI pr without prior discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2018
Problem and Mechanism
poll(2) currently clears registered interests after readiness and relies on IoSourceState::do_io to rearm them on WouldBlock
Raw unix::SourceFd registrations do not pass through that wrapper so later events are lost
This fix adds an internal per-registration rearm_on_io flag in the poll selector
Mio-owned I/O retains its existing rearm behavior on WouldBlock
Registrations via unix::SourceFd keep their interests enabled with level-triggered readiness
SourceFd documentation is updated to explain this behavior
No public API change
Regression Coverage
Two regression tests in tests/unix_sourcefd.rs use std UnixStream descriptors registered through SourceFd:
Tests exclude Miri and Emscripten due to existing Unix socketpair limitations
Validation
Limitations