Skip to content

@tolgee/format-icu declares no dependencies but its types import @tolgee/core #3530

Description

@bratzie

Super minor thing, but bumped into this while upgrading to the new 7.1.3 version of @tolgee/web (thank you for the patch!).

@tolgee/format-icu has no dependencies and no peerDependencies, yet its shipped
declarations import from @tolgee/core:

  • lib/FormatIcu.d.ts → import { TolgeePlugin } from '@tolgee/core'
  • lib/createFormatIcu.d.ts → import type { FinalFormatterMiddleware } from '@tolgee/core'
    Every sibling package declares what it imports — @tolgee/react → @tolgee/web,
    @tolgee/web → @tolgee/core, and @tolgee/i18next / @tolgee/svelte / @tolgee/vue
    → @tolgee/web. format-icu is the only one declaring nothing, which suggests an
    oversight rather than a deliberate choice.

Present in at least 5.33.2, 6.3.0, 7.0.0 and 7.1.3.

Suggested fix: either add @tolgee/core to format-icu's dependencies (matching
how @tolgee/web declares it), or re-point those two type imports at @tolgee/web and
declare that instead (matching the other plugin packages).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions