Add issue #121's ICH repro as a regression test - #122
Merged
JohnCampionJr merged 1 commit intoAug 31, 2026
Merged
Conversation
The mid-line smear was already fixed by tomlm#80's memmove guard inside CopyCellsFrom, but the issue's exact shape -- cursor placed by backspaces, and a gap wider than one cell -- had no named test. The count > 1 case exercises the overlap test with a shift distance the existing count-1 tests never reach. Closes tomlm#121. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JohnCampionJr
force-pushed
the
test/ich-midline-regression
branch
from
August 31, 2026 15:32
a0563c6 to
b9d5210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#121 reported the classic mid-line ICH smear (an overlapping forward copy replicating the cell under the cursor to the end of the row). It does not reproduce on current
main— the fix landed in #80, which gaveCopyCellsFrommemmove semantics (XTerm.NET/src/XTerm.NET/Buffer/BufferLine.cs
Lines 341 to 350 in 3760bf0
This just pins the issue's exact shape down with a named test: the cursor arrives mid-line by backspaces rather than CUP, and the gap can be wider than one cell. The
count > 1case exercises the overlap test insideCopyCellsFromwith a shift distance the existing count-1 regression tests from #80 never reach.Full suite green: 2,114 passed.
Closes #121.
🤖 Generated with Claude Code