fix: set SSE reconnect delay to 100ms - #246
Merged
Merged
Conversation
📊 Performance Metrics — PR vs mainmemory — ✅
postgres — ✅
cluster-valkey — ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Send
retry: 100\n\ninstead of the initial blank line in both v1 and v3 SSE handlers, using the existing immediate flush. Update the v3 write-error message to describe the new initial frame.This tells native
EventSourceclients to use a 100 ms reconnection interval. Without an explicit SSEretryfield, WebKit defaults to 3000 ms, which can add a noticeable delay when a backgrounded wallet reconnects.