Conversation
…eployment domain" This reverts commit 5acab9b.
…let) to reproduce the race with a real wallet
…storing injected connection Browser extensions (MV3 content scripts / service worker cold start) may inject window.<jsBridgeKey> after the dapp has already called restoreConnection(). Previously InjectedProvider constructor threw WalletNotInjectedError on the first attempt and the stored session was irreversibly removed, so the user got disconnected on every page reload that won the race. Now restoreConnection polls for the bridge to appear (up to 5s) and only clears the stored session if the wallet never shows up (i.e. extension was uninstalled).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.