fix: handle missing injected device info - #567
Open
circle-hotaru wants to merge 1 commit into
Open
Conversation
|
@circle-hotaru is attempting to deploy a commit to the TOP Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@thekiba @Alejandbel Please help review the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix injected wallet connection failure when a wallet provider does not expose
deviceInfo.Motivation
After analytics was added to the SDK,
InjectedProviderstarted reading:during initialization.
This makes analytics metadata mandatory at runtime. However, some already released wallet apps expose a valid injected TON Connect provider without deviceInfo. These wallets can still support the required connection methods, but the SDK throws before the connection flow can start:
TypeError: undefined is not an object (evaluating 'this.injectedWallet.deviceInfo.appName')
Wallet apps can add deviceInfo in future releases, but already released versions cannot be fixed retroactively. Since analytics should not block the core connection flow, the SDK should handle missing analytics metadata gracefully.