Skip to content

fix: wallet v5 proof read#1605

Draft
pyAndr3w wants to merge 2 commits intomainfrom
1342-wallet-v5-proof-read
Draft

fix: wallet v5 proof read#1605
pyAndr3w wants to merge 2 commits intomainfrom
1342-wallet-v5-proof-read

Conversation

@pyAndr3w
Copy link
Copy Markdown
Contributor

closes #1342

@pyAndr3w pyAndr3w changed the title wallet v5 proof read fix: wallet v5 proof read Dec 11, 2025
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates—there’s one inline suggestion in standard/wallets/how-it-works.mdx: please apply the inline suggestion to align the text with the documented style.

Comment on lines +68 to +72
<Aside
type="note"
title="Wallet V5 and `wallet_id`"
>
Wallet V5 replaces `subwallet_id` with a derived 32‑bit `wallet_id` field that encodes network, wallet version, workchain, and subwallet number in a single value. The on-chain getter is still named `get_subwallet_id()` for backward compatibility, but for Wallet V5 it returns this derived `wallet_id`. See the [Wallet V5 overview](/standard/wallets/v5#wallet-id-scheme) for the exact scheme.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Stub “See …” sentence in Wallet V5 aside

The Wallet V5 aside ends with a standalone sentence, “See the Wallet V5 overview for the exact scheme.” This is a “stub” sentence whose sole purpose is to tell the reader to “See …” a link, which the style guide explicitly forbids in running prose. The guideline requires integrating the link naturally into the sentence instead of wrapping it in meta text like “See …”. Rephrasing the sentence keeps the content intact while aligning with the documented link-text and stub-sentence style rule.

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

@novusnota novusnota marked this pull request as draft January 16, 2026 12:20
Copy link
Copy Markdown

@jamerson1994-cloud jamerson1994-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ue

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13c3029c-b376-4750-b49b-fb7397df0086

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1342-wallet-v5-proof-read

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wallets > v5] Proof read, improve

3 participants