feat(foundations): add Tact block proof validation guide#2001
feat(foundations): add Tact block proof validation guide#2001delovoyhomie wants to merge 1 commit intomainfrom
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
delovoyhomie
force-pushed
the
Merkle-proofs
branch
from
059bb13 to
f097248
Compare
|
/review |
| ## Trade-offs and assumptions | ||
|
|
||
| - Basechain only. `getShardRootHash` always reads `shardHashes.get(0)`. | ||
| - Recent masterchain blocks only. `PREVMCBLOCKS` exposes only the last 16 masterchain blocks. |
There was a problem hiding this comment.
actually you can use PREVMCBKLOCKS_100, that will give more space
|
|
||
| ## Trade-offs and assumptions | ||
|
|
||
| - Basechain only. `getShardRootHash` always reads `shardHashes.get(0)`. |
There was a problem hiding this comment.
but can be easily done for masterchain
|
|
||
| - Basechain only. `getShardRootHash` always reads `shardHashes.get(0)`. | ||
| - Recent masterchain blocks only. `PREVMCBLOCKS` exposes only the last 16 masterchain blocks. | ||
| - `ShardStateUnsplit` only. The code does not handle split shard states. |
There was a problem hiding this comment.
hmmm, it needs to be researched, I've never seen other type there. There is the chance, that the structure is always ShardStateUnsplit
| - Basechain only. `getShardRootHash` always reads `shardHashes.get(0)`. | ||
| - Recent masterchain blocks only. `PREVMCBLOCKS` exposes only the last 16 masterchain blocks. | ||
| - `ShardStateUnsplit` only. The code does not handle split shard states. | ||
| - Active accounts only. `parseStateFromShardAccount` assumes `AccountActive`. |
There was a problem hiding this comment.
Correct, but may be fixed. In any case, why one would need to proof inactive account?
| - Recent masterchain blocks only. `PREVMCBLOCKS` exposes only the last 16 masterchain blocks. | ||
| - `ShardStateUnsplit` only. The code does not handle split shard states. | ||
| - Active accounts only. `parseStateFromShardAccount` assumes `AccountActive`. | ||
| - No `StateInit` library support. The parser reads only `code` and `data`. |
There was a problem hiding this comment.
Valid point, can be fixed actually by correct StateInit parsing
novusnota
left a comment
novusnota
left a comment
There was a problem hiding this comment.
Cool, but:
- Page should be named
block-proof-validation.mdx, without a specific language prefix. - Let's switch from Tact to Tolk. We're currently trying to make the whole documentation use a single smart contract programming language. See #1966 and #1999.
There was an experimental rewrite of the same DEX in Tolk. Please, take a look at that and convert the Tact code on this page into Tolk.
This is related to #1442, where the same change is needed.
3 participants
Closes #1839