Skip to content

Improved file structure#2

Open
AkshatAggarwal14 wants to merge 2 commits intotr1ten:masterfrom
AkshatAggarwal14:master
Open

Improved file structure#2
AkshatAggarwal14 wants to merge 2 commits intotr1ten:masterfrom
AkshatAggarwal14:master

Conversation

@AkshatAggarwal14
Copy link

@AkshatAggarwal14 AkshatAggarwal14 commented Jul 2, 2023

This PR does two things:

  1. Move templates into different directories according to their language.
  2. Fix typos

@tr1ten
Copy link
Owner

tr1ten commented Jul 2, 2023

Thanks for the PR!
Nice work, I was wondering if we could use different naming conventions for file names.
currently, we use small cases for all languages except Java.
What do you think?

@AkshatAggarwal14
Copy link
Author

Thanks for the PR! Nice work, I was wondering if we could use different naming conventions for file names. currently, we use small cases for all languages except Java. What do you think?

i think we should use small cases for all languages

@AkshatAggarwal14 AkshatAggarwal14 requested a review from tr1ten July 2, 2023 14:55
"language": "Java",
"published": "2021-01-01",
"src": "java/IndexPriorityQueue.java"
"src": "java/index_priority_queue.java"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for inconvenience, but i think it would be better to keep java file name as their classname to avoid any confusion.
So please avoid renaming Java one's to small as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not running this code, so i dont think it matters if we change the case or not. If all files follow the same case, it looks consistent.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, someone may want to run templates to see if it's working.
I hope that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants