Repository navigation
Deliver agent work into the project + real build/test gate - #11
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
trac41799
force-pushed
the
hardening/production
branch
from
September 29, 2026 12:45
e417b09 to
a0aa944
Compare
… gate - wave_executor::merge_completed_agents: commit each completed agent's worktree, merge its branch into the base branch (--no-ff), remove the worktree only after merge; conflicts abort, are recorded, and the run pauses as awaiting_user with deploy skipped. Delivery evidence in report.artifacts[merges]. - PipelineAdapters::deliver enables delivery (production true; hermetic tests keep fake worktrees offline). - install_project_dependencies (npm ci/install, 900s cap, log tail on failure) runs before verification; failure fails the run. - verification::VerifyMode::RequireBuild turns the tooling-dependent checks from Skip into Fail so 'verification passed' cannot mean 'nothing was built'. - fix (found by the new step): exclude .acc/ bookkeeping from the delivery commit - per-agent GUIDELINE.md caused add/add conflicts on every merge after the first. Regression test gives each agent a distinct guideline and expects a clean 2/2 merge. - tests: 192 lib (+4): merge happy/conflict/skip, require-build mode. - docs: ACCEPTANCE-RUN-4.md. Gates: Rust 192 + 42; Web 341; tsc/lint clean. Real 2-agent run: succeeded, both files in the base project, conflicts: [].
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivers the missing half of the pipeline: agent work now lands in the project.
Delivery (merge-back)
wave_executor::merge_completed_agents: commits each completed agent's worktree, merges its branch into the base branch with--no-ff, and removes the worktree only after its work is merged. Conflicts abort the merge, are recorded, and the run pauses asawaiting_user(deploy skipped) — fail-closed, no half-merged project.PipelineAdapters::deliver(productiontrue; hermetic tests use non-git stand-in worktrees).report.artifacts["merges"].Real build/test gate
install_project_dependenciesrunsnpm ci/npm install(900 s cap, output captured to a log with the tail on failure) before verification; an install failure fails the run.verification::VerifyMode::RequireBuildturns the tooling-dependent checks (node_modules installed,npm run build passes,E2E runtime test) fromSkipintoFail, so "verification passed" can no longer mean "nothing was built". Lenient mode keeps hermetic tests unchanged.Defect found by the new step (fixed, with regression test)
First delivery attempt:
CONFLICT (add/add): .acc/GUIDELINE.md— each agent's worktree held its own generated guideline. Bookkeeping is now excluded from the commit via:(exclude).acc(no change to the user's git config); the merge tests give every agent a distinct guideline and still expect a clean 2/2 merge.Evidence
docs/2026-09-26-defect-closure/handoffs/ACCEPTANCE-RUN-4.md: real 2-agent run,succeeded,greeting_in_base_project=true,farewell_in_base_project=true,conflicts: [], 69.75 s.tsc/lintclean.Still not proven (documented, not faked)
scaffold_project→ install → real build/typecheck/runtime) run: the gate is implemented and unit-tested; the synthetic fixture has no real toolchain, so the acceptance run keepsinstall_deps=false.EXTERNAL-VERIFICATION.md.