Refactor/comptime option launch derive - #1513
Merged
Merged
Conversation
The hand-written ComptimeOptionArgs, LaunchArg impl, and ComptimeOptionCompilationArg with its five manual trait impls duplicate exactly what the CubeLaunch derive generates for enums, down to the type names, so the From<Option<RuntimeArg>> convenience impl compiles unchanged against the derived types.
Covers both variants, so the discriminant compiles one kernel each and the Some payload rides as a scalar binding.
nathanielsimard
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate your PR with burn.
It is important that you make sure that you don't introduce any bugs in burn.
Instructions