Repository navigation
Match CLI downloads to Assembly results - #611
Merged
Merged
Conversation
This was referenced Oct 23, 2026
kvz
marked this pull request as ready for review
October 23, 2026 16:56
* Report Assembly references and concise CLI failures * Preserve reporting output modes and sync legacy CLI docs * Skip empty ignored-error warning details * Report command failures once at the boundary * Preserve transport and batch failure diagnostics * Explain missing Template and steps inputs * Keep accepted Assembly references and sanitize parse failures * Retain creation attempt references and sync input errors * Limit ignored-error JSON to diagnostic fields * Validate Assembly diagnostic payloads before reporting * Include structured ignored-error details in CLI warnings
* Close upload file streams when Assembly creation fails * Track and close tus chunk streams on upload failure * Track tus chunks from caller-supplied file streams * Wait for pending file slices before rejecting Assembly creation * Stop sends after abort and clean up caller cancellation * Guard queued cancellation at the HTTP send boundary * Stop tus retry timers after startup cancellation * Allow upload listeners on the private cancellation signal * Synchronize retry cancellation tests with send attempts
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CLI downloads flatten HLS directories that playlists reference and save converted or bundled results under upload filenames. Public HTTP(S) inputs also fail before upload. Fixing those bugs must preserve the directory layout and freshness checks that existing scripts use.
Closes #593.
Closes #587.
Changes
<input>/<step>/…layout for multiple results.--reprocess-stalestill forces processing. Explicit file-output freshness behavior remains intact.meta.relative_path, separate independent source bundles, reserve linked paths together, and stage linked watch downloads before publishing them. Preserve source ownership across result reordering using the original path and filename. Reject unsafe paths and descendant symlinks.--url-download-timeout; watch mode requires local inputs.@transloadit/nodeandtransloadit, describing the layout repairs as bug fixes, per Kevin’s 2026-10-23 decision. Synchronize the generated legacy README.Removing input parent folders only relocates working files, so that change has been dropped from this PR. #621 tracks an opt-in layout instead. HLS directories and incorrect result filenames remain repaired.
#595 already fixed inputless directory downloads and non-TTY stdin. Both checkboxes are ticked on #593; live imports on main succeeded with
/dev/nulland socket-backed fd 0.Validation
/video/thumbsCLI run savedtestsrc_0.jpgwith verified JPEG bytes and no.mp4output.corepack yarn checkpasses, including all 1,119 Node tests (one test skipped), including 60 download-layout cases. Two live freshness E2E tests pass. Generated legacy-package sync and type checks pass.Final CI passes on
1d5bb2aa: all 14 checks, including Node 20/22/24/26, E2E, full verification, and fixtures. The single blockinggh-run-watchcompleted with exit 0.Review and follow-ups
Completed the two authorized review rounds on the rework diff only (DSP-473, option B, 2026-10-23), then stopped. All four retained findings are fixed:
No retained review finding remains unaddressed. The final freshness fix was tested after round 2; no third round was run.
Reviewer
tim-kosremains requested. The PR is assigned tokvzon project 12.Overlap
Rebased onto current main after #610 and #612 merged. #610’s CLI reporting and error formatting are preserved; shared
assemblies.tsandintentRuntime.tshunks cover download/path logic, transient-input metadata, and the URL download option. #612’s upload stream cleanup is preserved; this PR does not changeTransloadit.tsortus.ts.🤖 Claimed by kvz on
studio1/node-sdksince 2026-10-23 · resume:codex resume 01a16a73-d73f-7e11-83fe-db48d62fa526