Skip to content

ci: align pre-commit hooks and GitHub templates#449

Open
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates
Open

ci: align pre-commit hooks and GitHub templates#449
mc-nv wants to merge 17 commits into
mainfrom
mchornyi/TRI-1100/github-align-hooks-and-templates

Conversation

@mc-nv

@mc-nv mc-nv commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:

  • .pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralized add-license hook from the org .github repository (rev: v1.4.3 — excludes .github/ templates, never rewrites LICENSE files).
  • Pre-commit CI runs only on files modified by the PR.
  • Caller stub for the org-wide reusable conventional-pr workflow (@v1.4.3): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g. ci:CI/CD, feat:feature, fix:fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.
  • No per-repo templates: PR templates and issue routing are inherited from the org-wide defaults in triton-inference-server/.github (issues route to the server repository).

Depends on triton-inference-server/.github#5 (pinned tags current: v1.4.3 — already exist, CI is green).

Pros / Cons

Pros

  • Single home (org .github repo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.
  • Repos carry only a config file and two small workflow stubs; no template copies to drift.
  • Commit/PR title format enforced both locally (commit-msg hook) and in CI (reusable workflow), with automatic type labels.
  • License hooks never modify LICENSE files.

Cons / risks

  • Version-pinned dependency on the org .github repository (tags are write-once; changes ship as a new tag + rev bump).
  • Template inheritance requires the org .github repository to remain public.

Related Issues / PRs

  • Resolves: TRI-1100

Related PRs:

Test plan

  • pre-commit validate-config passes; pre-commit run --files <PR diff> passes locally with the centralized hooks pinned to the .github branch SHA.
  • After .github#5 merges and v1.4.3 exists: the conventional-pr check validates this PR's own title and applies the ci label.
  • No LICENSE file content is changed by this PR.

Caveats

  • None beyond the merge-order note above.

Checklist

  • PR title follows <commit_type>: <Title> (conventional commit)
  • I ran pre-commit locally on all files changed by this PR and it passes
  • Copyright header is correct on all changed files
  • External contributors: I have read the Contribution guidelines and signed the Contributor License Agreement

Adopt the shared pre-commit baseline: two-line SPDX header, conventional
commit message validation (commit-msg stage), and the centralized
add-license / add-spdx-license hooks from developer_tools v0.2.0.
Run pre-commit CI only on files modified by the PR, and roll out the
standard issue templates and the simplified single PR template.

TRI-1100
@mc-nv mc-nv self-assigned this Jul 18, 2026
This was referenced Jul 18, 2026
Legal's Copyright / License Header Guidance specifies the SPDX form
without a comma after the year.

TRI-1100
@mc-nv
mc-nv marked this pull request as ready for review July 18, 2026 02:04
Org-wide label color scheme and cherry-pick detection.

TRI-1100
Human-readable type labels with enforced descriptions and colors.

TRI-1100
@github-actions github-actions Bot added CI/CD Continuous integration and workflow changes (ci: PRs) and removed ci labels Jul 20, 2026
@github-actions github-actions Bot added the chore Maintenance work, no production code change (chore: PRs) label Jul 20, 2026
mc-nv added 3 commits July 21, 2026 08:15
The add-license hook now fails when the LICENSE copyright year is
stale.

TRI-1100
Workflow files are license-processed again (only templates excluded);
refresh the stale copyright year this repo's pre-commit workflow
carried.

TRI-1100
Grant issues:write to the labeling job (review feedback).

TRI-1100
@Vinya567

Copy link
Copy Markdown

@greptileai

@mc-nv
mc-nv requested a review from pskiran1 July 22, 2026 15:11
@Vinya567

Copy link
Copy Markdown

@greptileai

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR aligns the repository with the org-wide CI setup in triton-inference-server/.github, replacing per-repo workflow and hook implementations with thin caller stubs pinned to v1.4.3.

  • conventional-pr.yml: New caller-stub workflow that validates PR titles against Conventional Commits and applies type labels via the org-wide reusable workflow. Correctly gates same-repo PRs on pull_request and fork PRs on pull_request_target (for write-token access to label) while scoping permissions to pull-requests: write, issues: write, contents: read — the reusable workflow never checks out PR code.
  • pre-commit.yml: Migrates from pre-commit/action@v3.0.1 to a direct pip install + git diff | xargs invocation. Adds a pre-commit cache keyed on the config file hash, null-delimited path handling for filenames with spaces, --diff-filter=d to skip deleted files, and an explicit contents: read permission.
  • .pre-commit-config.yaml: Adds default_install_hook_types: [pre-commit, commit-msg], a conventional-pre-commit commit-msg hook, fixes a whitespace bug in the flake8 --extend-ignore arg, and moves the add-license hook source from developer_tools to triton-inference-server/.github@v1.4.3.

Confidence Score: 5/5

Safe to merge — changes are CI/tooling configuration only, with no production code modified.

All three files contain CI workflow and pre-commit configuration. The pull_request_target routing pattern is implemented correctly (mutually exclusive conditions, no PR code checkout, scoped permissions). The pre-commit pipeline change handles edge cases (spaces in paths, deletion-only PRs) properly. Both the workflow and the hook config pin to the same tag (v1.4.3), which is self-consistent. No logic errors or security gaps were identified.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/conventional-pr.yml New caller-stub workflow triggering the org-wide conventional-pr reusable workflow; correctly routes same-repo vs fork PRs to pull_request vs pull_request_target with scoped permissions and a pinned tag at v1.4.3.
.github/workflows/pre-commit.yml Replaces pre-commit/action with direct pip install + git diff xargs approach; adds pre-commit cache, least-privilege permissions, null-delimited path handling, and deleted-file filtering.
.pre-commit-config.yaml Adds default_install_hook_types for commit-msg stage, fixes flake8 arg quoting, adds conventional-pre-commit hook, and migrates add-license source from developer_tools to .github at v1.4.3.

Reviews (2): Last reviewed commit: "ci: harden CI workflows and configs per ..." | Re-trigger Greptile

Comment thread .github/workflows/conventional-pr.yml Outdated
permissions:
pull-requests: write
issues: write
uses: triton-inference-server/.github/.github/workflows/conventional-pr.yml@v1.4.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Version tag inconsistency with PR description

The PR description and checklist consistently reference v1.4.1 as the pinned tag (e.g. "Caller stub … @v1.4.1", "pinned tags current: v1.4.1 — already exist"), but the actual code pins v1.4.2 in both the workflow (@v1.4.2) and .pre-commit-config.yaml (rev: v1.4.2). The code is self-consistent, but the description would mislead anyone comparing it against the org .github repo. If v1.4.2 is intentional, the PR description should be updated to reflect it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - documentation drift: the descriptions have been refreshed to the current pinned tag v1.4.3 (they lagged behind the tag revisions; the tag exists and CI is green fleet-wide).

- conventional-pr stub: dual pull_request/pull_request_target triggers
  so fork PRs from external contributors get labeled too (the reusable
  workflow never checks out PR code); explicit contents:read; pinned
  v1.4.3.
- pre-commit workflow: robust modified-files runner (null-delimited
  paths, deletion-only PRs handled, deleted paths filtered, no
  undocumented -r flag, cache keyed on config hash).
- flake8 args quoted correctly (the flow-scalar form split at commas
  and silently reduced the select list).
- hooks pinned to .github v1.4.3.

TRI-1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work, no production code change (chore: PRs) CI/CD Continuous integration and workflow changes (ci: PRs)

Development

Successfully merging this pull request may close these issues.

2 participants