Skip to content

test: wire instance_queue_test into L0_batcher - #8905

Merged
Vinya567 merged 3 commits into
mainfrom
vinya/TRI-1626/l0-instance-queue
Jul 29, 2026
Merged

test: wire instance_queue_test into L0_batcher#8905
Vinya567 merged 3 commits into
mainfrom
vinya/TRI-1626/l0-instance-queue

Conversation

@Vinya567

@Vinya567 Vinya567 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Wire core instance_queue_test into the existing L0_batcher suite so CI runs it: copy bin/instance_queue_test into qa/L0_batcher/ from Dockerfile.QA, and invoke it from qa/L0_batcher/test.sh.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

  • test

Related PRs:

Where should the reviewer start?

  • Dockerfile.QAcp bin/instance_queue_test qa/L0_batcher/.
  • qa/L0_batcher/test.sh — runs the unit test alongside existing batcher coverage

Test plan:

  • Confirmed core#509 builds/installs instance_queue_test (CMake install to bin/)
  • Earlier internal CI with a dedicated L0 job passed both gtest cases; rewired into L0_batcher per review feedback (existing L0_batcher--base job covers it — no new GitLab job)
  • GitHub PR checks on this PR: pre-commit, CodeQL, Greptile

Before landing:

  • Land after core#509 so bin/instance_queue_test exists when Dockerfile.QA copies it (otherwise py3-devel fails)

Add L0_instance_queue runner and copy the core unit-test binary in
Dockerfile.QA so instance_queue_test actually executes in CI (TRI-1626).
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown

Greptile Summary

This PR wires the core instance-queue unit test into the existing L0 batcher suite.

  • Copies the installed instance_queue_test executable into the L0 batcher QA directory.
  • Runs the executable after the existing batcher tests and propagates a nonzero result through the suite’s existing failure status.

Confidence Score: 5/5

The PR appears safe to merge after its documented core dependency has landed.

No blocking failure remains within the scope of the prior review threads.

Important Files Changed

Filename Overview
Dockerfile.QA Packages the externally built instance_queue_test executable with the L0 batcher QA assets.
qa/L0_batcher/test.sh Executes the instance-queue unit test, captures its output, and incorporates failures into the suite result.

Reviews (3): Last reviewed commit: "Merge branch 'main' into vinya/TRI-1626/..." | Re-trigger Greptile

Move the unit test into the existing batcher L0 suite instead of a
separate L0_instance_queue path, per review feedback.
@Vinya567 Vinya567 changed the title test: wire instance_queue_test into L0 CI path test: wire instance_queue_test into L0_batcher Jul 29, 2026
@Vinya567
Vinya567 merged commit dde37f5 into main Jul 29, 2026
4 checks passed
@Vinya567
Vinya567 deleted the vinya/TRI-1626/l0-instance-queue branch July 29, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

2 participants