test: wire instance_queue_test into L0_batcher - #8905
Merged
Conversation
Add L0_instance_queue runner and copy the core unit-test binary in Dockerfile.QA so instance_queue_test actually executes in CI (TRI-1626).
Greptile SummaryThis PR wires the core instance-queue unit test into the existing L0 batcher suite.
Confidence Score: 5/5The PR appears safe to merge after its documented core dependency has landed. No blocking failure remains within the scope of the prior review threads. Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into vinya/TRI-1626/..." | Re-trigger Greptile |
Move the unit test into the existing batcher L0 suite instead of a separate L0_instance_queue path, per review feedback.
yinggeh
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Wire core
instance_queue_testinto the existingL0_batchersuite so CI runs it: copybin/instance_queue_testintoqa/L0_batcher/fromDockerfile.QA, and invoke it fromqa/L0_batcher/test.sh.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
Where should the reviewer start?
Dockerfile.QA—cp bin/instance_queue_test qa/L0_batcher/.qa/L0_batcher/test.sh— runs the unit test alongside existing batcher coverageTest plan:
instance_queue_test(CMakeinstalltobin/)L0_batcherper review feedback (existingL0_batcher--basejob covers it — no new GitLab job)Before landing:
bin/instance_queue_testexists whenDockerfile.QAcopies it (otherwise py3-devel fails)