test: Launch Dynamo QA worker via python -m dynamo.triton - #8908
Merged
Conversation
Match the frontend module entrypoint and the renamed dynamo.triton worker instead of invoking a script path.
Greptile SummaryUpdates Dynamo QA worker startup to use the renamed
Confidence Score: 5/5The PR appears safe to merge when used with the explicitly required Dynamo image containing the renamed The new module invocation matches the intended renamed entrypoint, existing repository callers do not rely on the removed override, and worker startup failures remain detected by the existing process-readiness path. Important Files Changed
Reviews (1): Last reviewed commit: "refactor: Launch Dynamo QA worker via py..." | Re-trigger Greptile |
Vinya567
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Update Dynamo launch mode in
qa/common/dynamo_util.shto start the Triton worker withpython3 -m dynamo.triton, matching the frontend (python3 -m dynamo.frontend) and the renamed Dynamo Triton entrypoint. Removes the oldDYN_WORKER_PYscript-path override and its file-existence check.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
qa/common/dynamo_util.sh— worker launch inrun_serverTest plan:
Exercise L0_infer (or another Dynamo-mode suite) with
SERVER_LAUNCH_MODE=dynamoagainst an image that includes the renameddynamo.tritonmoduleConfirm worker log shows
Running dynamo.triton ...and the process starts viapython3 -m dynamo.tritonCI Pipeline ID:
Caveats:
Depends on the Dynamo rename landing (or an image that already ships
python -m dynamo.triton).Background
The Dynamo Triton worker entrypoint is now
main.py/python -m dynamo.triton. QA still pointed at the oldtritonworker.pypath.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)