Skip to content

test: Launch Dynamo QA worker via python -m dynamo.triton - #8908

Merged
yinggeh merged 1 commit into
mainfrom
yinggeh/tri-1641-dynamotriton-fundamental-refactor
Jul 29, 2026
Merged

test: Launch Dynamo QA worker via python -m dynamo.triton#8908
yinggeh merged 1 commit into
mainfrom
yinggeh/tri-1641-dynamotriton-fundamental-refactor

Conversation

@yinggeh

@yinggeh yinggeh commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Update Dynamo launch mode in qa/common/dynamo_util.sh to start the Triton worker with python3 -m dynamo.triton, matching the frontend (python3 -m dynamo.frontend) and the renamed Dynamo Triton entrypoint. Removes the old DYN_WORKER_PY script-path override and its file-existence check.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • qa/common/dynamo_util.sh — worker launch in run_server

Test plan:

  • Exercise L0_infer (or another Dynamo-mode suite) with SERVER_LAUNCH_MODE=dynamo against an image that includes the renamed dynamo.triton module

  • Confirm worker log shows Running dynamo.triton ... and the process starts via python3 -m dynamo.triton

  • CI Pipeline ID:

Caveats:

Depends on the Dynamo rename landing (or an image that already ships python -m dynamo.triton).

Background

The Dynamo Triton worker entrypoint is now main.py / python -m dynamo.triton. QA still pointed at the old tritonworker.py path.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • No related GitHub issue

Match the frontend module entrypoint and the renamed dynamo.triton
worker instead of invoking a script path.
@yinggeh yinggeh self-assigned this Jul 29, 2026
@yinggeh
yinggeh requested a review from Vinya567 July 29, 2026 02:08
@yinggeh yinggeh added PR: refactor A code change that neither fixes a bug nor adds a feature PR: test Adding missing tests or correcting existing test labels Jul 29, 2026
@yinggeh yinggeh changed the title refactor: Launch Dynamo QA worker via python -m dynamo.triton test: Launch Dynamo QA worker via python -m dynamo.triton Jul 29, 2026
@yinggeh yinggeh removed the PR: refactor A code change that neither fixes a bug nor adds a feature label Jul 29, 2026
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

Updates Dynamo QA worker startup to use the renamed dynamo.triton Python module.

  • Removes the obsolete script-path override and file-existence check.
  • Retains existing worker arguments, discovery configuration, logging, readiness checks, and teardown behavior.

Confidence Score: 5/5

The PR appears safe to merge when used with the explicitly required Dynamo image containing the renamed dynamo.triton module.

The new module invocation matches the intended renamed entrypoint, existing repository callers do not rely on the removed override, and worker startup failures remain detected by the existing process-readiness path.

Important Files Changed

Filename Overview
qa/common/dynamo_util.sh Replaces the external worker-script invocation with python3 -m dynamo.triton; no actionable changed-code defect was identified.

Reviews (1): Last reviewed commit: "refactor: Launch Dynamo QA worker via py..." | Re-trigger Greptile

@yinggeh
yinggeh merged commit 0043697 into main Jul 29, 2026
4 checks passed
@yinggeh
yinggeh deleted the yinggeh/tri-1641-dynamotriton-fundamental-refactor branch July 29, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

2 participants