Skip to content

fix: unblock CI for minisatip, jackett, k8s-sidecar renovate bumps #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crow-Control merged 2 commits into from
Apr 17, 2026
Merged

fix: unblock CI for minisatip, jackett, k8s-sidecar renovate bumps #1824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a418590
fix: resolve failing PRs for minisatip, jackett, k8s-sidecar
Copilot Apr 17, 2026
41805b0
chore(minisatip): use modern cmake --build -j idiom
Copilot Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/jackett/container-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@
http:
- port: '9117'
path: /
statusCode: 302
2 changes: 1 addition & 1 deletion apps/jackett/docker-bake.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ variable "APP" {

variable "VERSION" {
// renovate: datasource=github-releases depName=Jackett/Jackett
default = "v0.24.1167"
default = "v0.24.1614"
}

variable "LICENSE" {
Expand Down
22 changes: 12 additions & 10 deletions apps/k8s-sidecar/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,19 @@ RUN apt-get update && \
# Create virtual environment and upgrade pip/setuptools
RUN python -m venv /app/venv && /app/venv/bin/pip install --no-cache-dir -U pip setuptools

# Download and extract only the src/ folder from the release
# Download and extract the release. Upstream moved dependency metadata from
# src/requirements.txt to a top-level pyproject.toml starting at 2.5.5, so we
# stage the whole project for pip and copy the source files into /app for the
# existing CMD to find.
ENV RELEASE_URL="https://github.com/kiwigrid/k8s-sidecar/archive/refs/tags/${VERSION}.tar.gz"
RUN curl -L https://github.com/kiwigrid/k8s-sidecar/archive/refs/tags/${VERSION}.tar.gz -o release.tar.gz && \
mkdir src_temp && \
tar -xzf release.tar.gz -C src_temp k8s-sidecar-${VERSION}/src && \
cp -r src_temp/k8s-sidecar-${VERSION}/src/* /app/ && \
rm -rf release.tar.gz src_temp

# Install Python dependencies
RUN /app/venv/bin/pip install --no-cache-dir -r requirements.txt && \
rm requirements.txt && \
RUN curl -L https://github.com/kiwigrid/k8s-sidecar/archive/refs/tags/${VERSION}.tar.gz -o /tmp/release.tar.gz && \
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_URL is defined but not used (the curl command repeats the URL literal). Consider either using ${RELEASE_URL} in the download step or dropping the ENV line to avoid drift/misleading configuration.

Suggested change
RUN curl -L https://github.com/kiwigrid/k8s-sidecar/archive/refs/tags/${VERSION}.tar.gz -o /tmp/release.tar.gz && \
RUN curl -L "${RELEASE_URL}" -o /tmp/release.tar.gz && \

Copilot uses AI. Check for mistakes.
mkdir -p /tmp/src_temp && \
tar -xzf /tmp/release.tar.gz -C /tmp/src_temp \
k8s-sidecar-${VERSION}/pyproject.toml \
k8s-sidecar-${VERSION}/src && \
Comment on lines +17 to +26
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says we “stage the whole project”, but the tar extraction only pulls pyproject.toml and src/. Please either adjust the comment to match what’s actually extracted, or extract the full k8s-sidecar-${VERSION}/ directory so the wording stays accurate and future packaging files aren’t accidentally omitted.

Copilot uses AI. Check for mistakes.
/app/venv/bin/pip install --no-cache-dir /tmp/src_temp/k8s-sidecar-${VERSION} && \
cp -r /tmp/src_temp/k8s-sidecar-${VERSION}/src/* /app/ && \
rm -rf /tmp/release.tar.gz /tmp/src_temp && \
# Remove tests and compiled Python files
find /app/venv \( -type d -name test -o -name tests \) -o \( -type f -name '*.pyc' -o -name '*.pyo' \) -exec rm -rf '{}' +

Expand Down
2 changes: 1 addition & 1 deletion apps/k8s-sidecar/docker-bake.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ variable "APP" {

variable "VERSION" {
// renovate: datasource=docker depName=ghcr.io/kiwigrid/k8s-sidecar
default = "2.5.2"
default = "2.6.0"
}

variable "LICENSE" {
Expand Down
8 changes: 6 additions & 2 deletions apps/minisatip/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ RUN \
apt-get update && \
apt-get install --no-install-recommends -y \
build-essential \
cmake \
git \
libdvbcsa-dev \
libssl-dev \
Expand All @@ -31,11 +32,14 @@ RUN \
/tmp/satip.tar.gz -C \
/app/satip --strip-components=1 && \
cd /app/satip && \
./configure && \
make DDCI=1 && \
cmake -B build . && \
cmake --build build -j"$(nproc)" && \
mv /app/satip/build/minisatip /app/satip/minisatip && \
rm -rf /app/satip/build && \
echo "**** clean up ****" && \
apt-get -y purge \
build-essential \
cmake \
git \
libssl-dev \
linux-headers-generic \
Expand Down
2 changes: 1 addition & 1 deletion apps/minisatip/docker-bake.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ variable "APP" {

variable "VERSION" {
// renovate: datasource=github-releases depName=catalinii/minisatip
default = "2.0.71"
default = "2.0.79"
}

variable "LICENSE" {
Expand Down