PD-2512 Private Datasets Tutorial Content Improvements in 26#4452
Open
micjohnson777 wants to merge 11 commits intomasterfrom
Open
PD-2512 Private Datasets Tutorial Content Improvements in 26#4452micjohnson777 wants to merge 11 commits intomasterfrom
micjohnson777 wants to merge 11 commits intomasterfrom
Conversation
To improve the overall flow of the procedure, some related sections are hidden behind expands to allow users the choice to read the content if they need the instructions in each collapsed section or to skip over it to continue with the private dataset procedure.
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 101 issues found in changed files - 11 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/SCALETutorials/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (39 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
micjohnson777
changed the title
Contributor
Author
|
Fixed the PR heading, changing it from the last commit to the PR objective |
fix line 166
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 101 issues found in changed files - 11 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/SCALETutorials/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (39 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 101 issues found in changed files - 11 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (39 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Fixed internal link in line171 changing before you begin to Checking Parent Dataset File Permissions section
Fixed line 8, oddly worded sentence
remove second "a" in line 25
fixed typos
fix typos
add missing period in line 10
add "in" to line 25
Contributor
Author
|
fixed typos, missing content. Ready for team review now |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 101 issues found in changed files - 11 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (39 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
1 similar comment
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 101 issues found in changed files - 11 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (39 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 100 issues found in changed files - 10 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (38 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 100 issues found in changed files - 10 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (38 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
2 similar comments
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 100 issues found in changed files - 10 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (38 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 100 issues found in changed files - 10 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (38 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 100 issues found in changed files - 10 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (38 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues📊 Summary: 100 issues found in changed files - 10 errors, 0 warnings, 90 suggestions Changed files with issues: content/SCALE/Shares/SMB/SMBPrivateDatasetShare.md (60 issues)
static/includes/AddingAUser.md (38 issues)
static/includes/ShareACLDialogs.md (2 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve the overall flow of the procedure, some related sections are hidden behind expands to allow users the choice to read the content if they need the instructions in each collapsed section or to skip over it to continue with the private dataset procedure.
This procedure does not backport as it includes 26 only content. A separate procedure for the 25.10 branch will be submitted based on 25.10 UI content.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.