Skip to content

Conversation

@shahzadhaider1
Copy link
Contributor

Summary (Optional Enhancement)

Simplify JiraInstallationType enum value names to improve readability.

Changes

Before:

enum JiraInstallationType {
  JIRA_INSTALLATION_TYPE_AUTODETECT = 0;
  JIRA_INSTALLATION_TYPE_CLOUD = 1;
  JIRA_INSTALLATION_TYPE_DATA_CENTER = 2;
}

After:

enum JiraInstallationType {
  JIRA_AUTODETECT = 0;
  JIRA_CLOUD = 1;
  JIRA_DATA_CENTER = 2;
}

Rationale

The initial naming used JIRA_INSTALLATION_TYPE_ prefix to avoid collisions with Bitbucket's enum values in the same proto package. However, this was unnecessarily verbose compared to Bitbucket's cleaner naming pattern.

The shorter JIRA_ prefix:

  • Still avoids package-level enum collisions
  • Matches Bitbucket's naming pattern for consistency
  • Improves readability

Generated Code Impact

// Before
sourcespb.JiraInstallationType_JIRA_INSTALLATION_TYPE_CLOUD

// After  
sourcespb.JiraInstallationType_JIRA_CLOUD

Breaking Changes

None

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

… prefix instead of JIRA_INSTALLATION_TYPE_ to improve readability while maintaining collision avoidance.
@shahzadhaider1 shahzadhaider1 requested a review from a team December 1, 2025 09:07
@shahzadhaider1 shahzadhaider1 requested review from a team as code owners December 1, 2025 09:07
@shahzadhaider1 shahzadhaider1 requested a review from a team as a code owner December 2, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant