Skip to content

(Fix): Handle CircleCI PR number parsing properly#1084

Merged
trunk-io[bot] merged 1 commit intomainfrom
tyler/circleci-parsing-pr
Apr 28, 2026
Merged

(Fix): Handle CircleCI PR number parsing properly#1084
trunk-io[bot] merged 1 commit intomainfrom
tyler/circleci-parsing-pr

Conversation

@TylerJang27
Copy link
Copy Markdown
Collaborator

As noted in the docs, CIRCLE_PR_NUMBER is only set on forked pull requests

We'll need to update our ref for this to take effect

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 28, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@TylerJang27
Copy link
Copy Markdown
Collaborator Author

@claude review

@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented Apr 28, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.01%. Comparing base (10de8fd) to head (e83aadc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   81.74%   82.01%   +0.27%     
==========================================
  Files          69       69              
  Lines       14907    14917      +10     
==========================================
+ Hits        12185    12234      +49     
+ Misses       2722     2683      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 28, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io trunk-io Bot merged commit a5dce4e into main Apr 28, 2026
25 checks passed
Copy link
Copy Markdown
Member

@dfrankland dfrankland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants