POC: DRY up Flaky Tests framework pages with shared includes#547
POC: DRY up Flaky Tests framework pages with shared includes#547samgutentag wants to merge 8 commits intomainfrom
Conversation
Reference copy of the prompt used in the RemoteTrigger configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Design spec, implementation plan, transition plan, and self-contained prompts for two RemoteTrigger agents: - Daily scanner: scans trunk2 merged PRs at 4 AM PT, creates docs PRs, changelog tickets, and roadmap updates - Deploy watcher: polls for new deploy tags every 2 hours, runs full release-comms pipeline Both triggers are live on Anthropic cloud infrastructure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pivoted from RemoteTrigger (CCR MCP unavailable) to local crontab. Both prompts now live in gutils/TRUNK/skills-devrel-pipeline/ and are symlinked into docs/superpowers/specs/. Transition plan updated with full state log of the pivot. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Create try-it-locally.md include (validate command tabs + test upload section) and convert jest.md to use it alongside existing checklist.md, retries.md, and ci-providers.md includes. Reduces jest.md from 137 lines to 51 (63% reduction). Also removes the duplicate inline CI provider card grid that appeared below the include. Adds in-app onboarding callout to the getting started page for users who already have a Trunk account. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Claude finished @samgutentag's task in 2m 23s —— View job PR Review
SummaryThe core changes are well-executed. The BlockingBroken symlinks in
Both symlinks point to absolute paths on the author's local machine and are broken for everyone else. The full prompt content is already documented in the plan file, so these can either be replaced with actual file content or removed entirely. Non-blocking
What looks good
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| You can find your Trunk organization slug and token in the settings or by following these [instructions](https://docs.trunk.io/flaky-tests/get-started/ci-providers/otherci#id-1.-store-a-trunk_token-secret-in-your-ci-system). After your upload, you can verify that Trunk has received and processed it successfully in the **Uploads** tab. Warnings will be displayed if the report has issues. | ||
|
|
||
| <figure><picture><source srcset="../assets/data-uploads-dark.png" media="(prefers-color-scheme: dark)"><img src="../assets/data-uploads-light.png" alt=""></picture><figcaption></figcaption></figure> |
There was a problem hiding this comment.
Image path may not resolve correctly — needs GitBook preview verification.
The paths ../assets/data-uploads-dark.png and ../assets/data-uploads-light.png are relative to this include file's location (.gitbook/includes/), resolving to .gitbook/assets/. This is consistent with the original jest.md paths (../../../.gitbook/assets/...) and should be correct if GitBook resolves relative paths from the include file's location.
However, if GitBook resolves relative paths from the consuming file's location instead, these will break. The PR test plan already calls this out — just confirming the risk is real and requires preview validation before merging.
|
|
||
| Before modifying your CI jobs to automatically upload test results to Trunk, try uploading a single test run manually. | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
Minor inconsistency: the validate command blocks use ```bash but the upload block uses ```sh. Consider standardizing to bash throughout for consistency.
| ```sh | |
| ```bash |
| Trunk Flaky Tests detects flaky tests by analyzing test results from your CI runs. Setup requires configuring test result output and CI upload integration. | ||
|
|
||
| {% hint style="info" %} | ||
| **Interactive setup available** — If you have a Trunk account, the [in-app onboarding guide](https://app.trunk.io) walks you through configuration with instructions tailored to your test framework and CI provider. |
There was a problem hiding this comment.
The link here goes to https://app.trunk.io (the app root) rather than a specific onboarding URL. If there's a dedicated onboarding page or deep link, using it would give users a more direct path. If the root URL is intentional (because onboarding starts from login), this is fine as-is.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- retries.md: fix "retried" → "retries" typo - checklist.md: fix broken-reference link, change H2 to H3, tighten copy - ci-providers.md: remove TeamCity card (no page exists, link was broken) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace inline boilerplate (checklist, retries warning, validate/upload tabs, CI provider card grid) with shared GitBook includes across all JUnit XML framework pages. Preserves all framework-specific content (install commands, config snippets, retries notes, troubleshooting). Reduces total line count by ~2,030 lines across 24 files. Skipped bazel.md, xctest.md, and rspec/ which need custom handling due to different report formats. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @samgutentag's task in 2m 11s —— View job Claude finished @samgutentag's task —— PR Review
SummaryThe previous blocking issue (broken symlinks in The mass conversion of 24 framework pages looks clean. The shared includes are correctly wired, framework-specific content is preserved throughout, and the two bug fixes ( Non-blockingCode fence inconsistency in Image paths ( What looks good
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Create 3 new includes (stable-branches-hint, stale-files-warning, platform-hint) and convert all 12 CI provider pages to use them alongside existing includes (ci-provider-checklist, slug/token, not-using-github, have-questions). Fix heading levels in trunk-organization-slug-and include (H2 to H3) and replace "Ensure" with "Make sure". Removes ~497 lines of duplicated boilerplate. Provider-specific content (secrets setup, YAML examples, GitHub Actions quarantining) preserved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @samgutentag's task in 2m 27s —— View job Claude finished @samgutentag's task —— PR Review
SummaryNo blocking issues. The previous blocker (broken symlinks) was resolved in commit Non-blockingCode fence inconsistency in Image paths ( What looks good
|
|
|
||
| Before modifying your CI jobs to automatically upload test results to Trunk, try uploading a single test run manually. | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
Minor inconsistency (previously flagged, still outstanding): the upload block uses ```sh while all four validate blocks above use ```bash. Suggested fix:
| ```sh | |
| ```bash |
1 participant
Summary
try-it-locally.mdinclude (validate command tabs + test upload section) shared across all JUnit XML framework pagesjest.mdas proof of concept: 137 lines → 51 lines (63% reduction)Scope
This is a proof of concept — only jest.md is converted. If the GitBook preview looks correct, the same pattern will be applied to the other ~22 JUnit XML framework pages.
Pages that need custom handling (not this pattern): bazel.md, xctest.md, rspec/
Test plan
🤖 Generated with Claude Code