docs(flaky-tests): document monitor preview panel status filter#587
Draft
samgutentag wants to merge 1 commit intomainfrom
Draft
docs(flaky-tests): document monitor preview panel status filter#587samgutentag wants to merge 1 commit intomainfrom
samgutentag wants to merge 1 commit intomainfrom
Conversation
Adds a Preview Panel section to both the failure count and failure rate monitor pages describing the new multi-select status filter dropdown (Healthy / Flaky / Broken), truncation handling on the failure count panel, and the collapsed-Current default on the failure rate panel. Source: trunk-io/trunk2#3732 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Claude finished @samgutentag's task in 1m 28s —— View job PR Review
The documentation additions are clear, well-structured, and accurately describe the preview panel behavior. One minor grammar fix suggested via inline comment. Findings:
Minor observations (non-blocking):
Overall the PR is in good shape. The one inline suggestion is a minor grammar fix and not blocking. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| - **Current** shows tests flagged by the existing configuration (if editing an existing monitor). | ||
| - **Proposed** shows tests that would be flagged with the settings currently entered in the form. | ||
|
|
||
| The Current section is collapsed by default so the Proposed view is immediately visible when you open the form. |
Contributor
There was a problem hiding this comment.
Missing comma before "so" in this compound sentence.
Suggested change
| The Current section is collapsed by default so the Proposed view is immediately visible when you open the form. | |
| The Current section is collapsed by default, so the Proposed view is immediately visible when you open the form. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Adds a Preview Panel section to the failure count monitor page describing the status filter dropdown (Healthy / Flaky / Broken), truncation handling, and how the filter affects the info tooltip.\n- Adds a Preview Panel section to the failure rate monitor page describing the status filter dropdown, the collapsed-Current default, and how the filter interacts with the Proposed vs Current sections.\n\n## Source\n- trunk2 PR: https://github.com/trunk-io/trunk2/pull/3732\n\n## Test plan\n- [ ] Preview in GitBook
Generated by Claude Code