Add Chrome Extension documentation#588
Conversation
Documents the Trunk Chrome Extension that overlays merge queue controls onto GitHub PR pages: install, submit, cancel, track testing progress, plus a security note explaining session-based auth via app.trunk.io. Image references are placeholders to be filled in once UI assets land.
Replaces the placeholder Chrome Web Store URL with the published extension listing and notes that Chrome admins can force-install it org-wide via the Google Workspace admin console.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Claude finished @EliSchleifer's task in 2m 2s —— View job PR Review
Overall the documentation is well-structured and comprehensive. The content, security explanation, and FAQ section are clear and accurate. A few polish items to address: Issues found (all non-blocking):
No typos, no broken internal links, no factual errors found. The navigation entry in |
| The extension is a companion to Trunk Merge Queue — you still need a [configured queue](getting-started/) for your repository. The extension only surfaces controls and status for queues your Trunk organization already owns. | ||
| {% endhint %} | ||
|
|
||
| <!-- TODO: hero screenshot of the extension overlay on a GitHub PR page --> |
There was a problem hiding this comment.
The `` comment should be removed — the actual <figure> with the image follows immediately on the next lines. Same pattern applies on lines 30, 44, 57, and 72.
| <!-- TODO: hero screenshot of the extension overlay on a GitHub PR page --> |
|
|
||
| <!-- TODO: hero screenshot of the extension overlay on a GitHub PR page --> | ||
|
|
||
| <figure><img src="../.gitbook/assets/chrome-extension-overview.png" alt=""><figcaption>The Trunk overlay on a GitHub pull request page.</figcaption></figure> |
There was a problem hiding this comment.
All <figure> tags in this file have empty alt="" attributes. Alt text is important for accessibility and should describe the image content.
| <figure><img src="../.gitbook/assets/chrome-extension-overview.png" alt=""><figcaption>The Trunk overlay on a GitHub pull request page.</figcaption></figure> | |
| <figure><img src="../.gitbook/assets/chrome-extension-overview.png"><figcaption>The Trunk overlay on a GitHub pull request page.</figcaption></figure> |
|
|
||
| <!-- TODO: screenshot of Chrome Web Store listing --> | ||
|
|
||
| <figure><img src="../.gitbook/assets/chrome-extension-install.png" alt=""><figcaption></figcaption></figure> |
There was a problem hiding this comment.
Both the alt attribute and caption are empty. Consider adding descriptive text.
| <figure><img src="../.gitbook/assets/chrome-extension-install.png" alt=""><figcaption></figcaption></figure> | |
| <figure><img src="../.gitbook/assets/chrome-extension-install.png"><figcaption>The Trunk Merge Queue extension in the Chrome Web Store.</figcaption></figure> |
|
|
||
| <!-- TODO: screenshot of the Cancel control in the extension panel --> | ||
|
|
||
| <figure><img src="../.gitbook/assets/chrome-extension-cancel.png" alt=""><figcaption></figcaption></figure> |
There was a problem hiding this comment.
Empty alt and empty caption — same issue as line 32. Please add descriptive text to both.
| <figure><img src="../.gitbook/assets/chrome-extension-cancel.png" alt=""><figcaption></figcaption></figure> | |
| <figure><img src="../.gitbook/assets/chrome-extension-cancel.png"><figcaption>Cancelling a PR from the merge queue via the extension panel.</figcaption></figure> |
| * **Tests Passed** — waiting for upstream PRs before merging | ||
| * **Merged**, **Failed**, or **Cancelled** — terminal states | ||
|
|
||
| The panel shows the current state, time spent in queue, and any upstream PRs whose results this PR depends on. A link jumps to the full PR detail page in the Trunk web app for deeper context. |
There was a problem hiding this comment.
Minor grammar: "time spent in queue" should be "time spent in the queue".
| The panel shows the current state, time spent in queue, and any upstream PRs whose results this PR depends on. A link jumps to the full PR detail page in the Trunk web app for deeper context. | |
| The panel shows the current state, time spent in the queue, and any upstream PRs whose results this PR depends on. A link jumps to the full PR detail page in the Trunk web app for deeper context. |
Removes the redundant <!-- TODO --> comments above each figure (the figure tags themselves serve as the placeholders), adds descriptive figcaptions to the two install/cancel figures that were empty, and fixes "in queue" → "in the queue" in the testing-progress section. Keeps alt="" to match the existing repo convention.
|
Claude finished @EliSchleifer's task in 43s —— View job PR Review
All issues from the previous review have been resolved:
The navigation entry in |
|
Claude finished @EliSchleifer's task in 59s —— View job PR Review
This PR adds well-structured documentation for the Trunk Chrome Extension. All issues from previous review rounds have been resolved:
Additional checks performed:
No blocking issues found. Review passed. |
Summary
This PR adds comprehensive documentation for the Trunk Chrome Extension, a new feature that allows users to submit, cancel, and track Merge Queue pull requests directly from GitHub without leaving the PR page.
Changes
New documentation file:
merge-queue/chrome-extension.md(121 lines)/trunk mergecommentUpdated navigation: Modified
summary.mdto add the new Chrome Extension page to the merge-queue documentation section, positioned between "Integration for Slack" and "Webhooks"Notable Details
https://claude.ai/code/session_01Gjf9LGizwRF2HEW4w587yC