docs(security): document clickjacking protection#590
Draft
samgutentag wants to merge 1 commit intomainfrom
Draft
docs(security): document clickjacking protection#590samgutentag wants to merge 1 commit intomainfrom
samgutentag wants to merge 1 commit intomainfrom
Conversation
…ders Trunk now sets Content-Security-Policy: frame-ancestors 'self' and X-Frame-Options: SAMEORIGIN on all frontend routes, addressing a customer clickjacking report. Trunk2 PR #3775, shipped in v164. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> https://claude.ai/code/session_014qULqFuLwEDqNLt4pr2iNu
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Claude finished @samgutentag's task in 1m 4s —— View job PR Review Complete
Review SummaryThe change adds one bullet point to the Infrastructure Security section documenting clickjacking protection via anti-framing headers. Overall this is accurate, well-formatted, and consistent with the existing style in the section. Positives:
Minor suggestion (non-blocking):
No blocking issues found. ✓ |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| * **Encryption in transit**: All data transmitted to and from Trunk uses TLS (Transport Layer Security) and HSTS | ||
| * **Encryption at rest**: All customer data is encrypted using AES-256 | ||
| * **Network isolation**: Production services run in isolated AWS VPCs with restricted access; all services are within private subnets with no internet access and use a network gateway to permit specific traffic | ||
| * **Clickjacking protection**: All Trunk app pages set `Content-Security-Policy: frame-ancestors 'self'` and `X-Frame-Options: SAMEORIGIN`, preventing Trunk pages from being embedded in external iframes |
Contributor
There was a problem hiding this comment.
Minor nit (non-blocking): "embedded in external iframes" is slightly redundant since iframes are inherently an embedding mechanism. Consider tightening to "framed by external sites" for clarity.
Suggested change
| * **Clickjacking protection**: All Trunk app pages set `Content-Security-Policy: frame-ancestors 'self'` and `X-Frame-Options: SAMEORIGIN`, preventing Trunk pages from being embedded in external iframes | |
| * **Clickjacking protection**: All Trunk app pages set `Content-Security-Policy: frame-ancestors 'self'` and `X-Frame-Options: SAMEORIGIN`, preventing Trunk pages from being framed by external sites |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Security-Policy: frame-ancestors 'self'andX-Frame-Options: SAMEORIGINto prevent clickjackingContext
This documents trunk2 PR #3775 (shipped in v164), which addressed a customer clickjacking report by adding anti-framing headers to all frontend routes.
Test plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
https://claude.ai/code/session_014qULqFuLwEDqNLt4pr2iNu
Generated by Claude Code