Skip to content

docs(flaky-tests): note automatic PR number detection on CircleCI#592

Draft
samgutentag wants to merge 1 commit intomainfrom
sam-gutentag/circleci-pr-number-detection
Draft

docs(flaky-tests): note automatic PR number detection on CircleCI#592
samgutentag wants to merge 1 commit intomainfrom
sam-gutentag/circleci-pr-number-detection

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Documents that the Trunk Analytics CLI automatically detects the pull request number from CircleCI environment variables
  • No extra configuration is needed for PR-level test attribution on CircleCI

Source

Test plan

  • Preview in GitBook

Generated by Claude Code

The Trunk Analytics CLI detects PR context from CircleCI environment
variables automatically, including the pull request number (trunk2 PR #3781).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trunk-staging-io
Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 30, 2026

Claude finished @samgutentag's task in 36s —— View job


Review

  • Gather context and read changed files
  • Review documentation changes

The change is a clean, well-placed addition. Here's my assessment:

What the PR does: Adds an info hint block to flaky-tests/get-started/ci-providers/circleci.md (lines 44–46) noting that the Trunk Analytics CLI auto-detects PR context from CircleCI environment variables, so no extra configuration is needed.

Placement: ✅ Correctly positioned right after the "Upload Test Results" step instructions — exactly where a user might wonder if additional PR configuration is needed.

Grammar & spelling: ✅ No errors found.

Formatting: ✅ Uses the GitBook {% hint style="info" %} syntax consistently with the rest of the file.

Minor observation (non-blocking): The phrase "detects PR context from CircleCI environment variables, including the pull request number" is slightly redundant — "PR context" already implies PR number. A tighter alternative could be:

The Trunk Analytics CLI automatically detects the pull request number from CircleCI environment variables. No additional configuration is needed to associate test uploads with the correct PR in Trunk.

But the current wording is perfectly readable and not incorrect, so this is just a style note.

Result: ✅ Approved — no blocking issues.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants