Skip to content

Update mypy to latest numbers #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EliSchleifer wants to merge 3 commits into
base: main
Choose a base branch
from
+144 −3
Open

Update mypy to latest numbers #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7ccc8b
EliSchleifer Apr 28, 2026
69efdc5
Update plugin.yaml
EliSchleifer Apr 28, 2026
584d7bb
Update plugin.yaml
EliSchleifer Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linters/mypy/mypy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const versionGreaterThanOrEqual = (a: string, b: string) => [a.split(".")] >= [b
const manualVersionReplacer = (version: string) => {
const [major, minor] = version.split(".").map((part) => Number.parseInt(part, 10));
if (!Number.isNaN(major) && !Number.isNaN(minor) && major === 1 && minor >= 20) {
return "1.18.2";
return "1.20.2";
}
return version;
};
Expand Down
4 changes: 2 additions & 2 deletions linters/mypy/plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ tools:
runtime: python
package: mypy
shims: [mypy]
known_good_version: 1.18.2
known_good_version: 1.20.2
lint:
definitions:
- name: mypy
Expand All @@ -30,7 +30,7 @@ lint:
- setup.cfg
suggest_if: config_present
issue_url_format: https://mypy.readthedocs.io/en/stable/error_code_list.html
known_good_version: 1.18.2
known_good_version: 1.20.2
version_command:
parse_regex: ${semver}
run: mypy --version
141 changes: 141 additions & 0 deletions linters/mypy/test_data/mypy_v1.20.2_CUSTOM.check.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Testing linter mypy test CUSTOM 1`] = `
{
"issues": [
{
"code": "arg-type",
"column": "10",
"file": "test_data/basic.py",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://mypy.readthedocs.io/en/stable/error_code_list.html",
"level": "LEVEL_HIGH",
"line": "13",
"linter": "mypy",
"message": "Argument 1 to "greeting" has incompatible type "int"; expected "str"",
"targetType": "python",
},
{
"code": "arg-type",
"column": "10",
"file": "test_data/basic.py",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://mypy.readthedocs.io/en/stable/error_code_list.html",
"level": "LEVEL_HIGH",
"line": "14",
"linter": "mypy",
"message": "Argument 1 to "greeting" has incompatible type "bytes"; expected "str"",
"targetType": "python",
},
{
"code": "func-returns-value",
"column": "5",
"file": "test_data/basic.py",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://mypy.readthedocs.io/en/stable/error_code_list.html",
"level": "LEVEL_HIGH",
"line": "15",
"linter": "mypy",
"message": ""printer" does not return a value (it only ever returns None)",
"targetType": "python",
},
{
"code": "assignment",
"column": "10",
"file": "test_data/basic.py",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://mypy.readthedocs.io/en/stable/error_code_list.html",
"level": "LEVEL_HIGH",
"line": "16",
"linter": "mypy",
"message": "Incompatible types in assignment (expression has type "int", variable has type "str")",
"targetType": "python",
},
{
"code": "attr-defined",
"column": "1",
"file": "test_data/basic.py",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://mypy.readthedocs.io/en/stable/error_code_list.html",
"level": "LEVEL_HIGH",
"line": "3",
"linter": "mypy",
"message": "Module "test_data" has no attribute "mypy_import2"",
"targetType": "python",
},
{
"code": "return",
"column": "1",
"file": "test_data/source.py",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://mypy.readthedocs.io/en/stable/error_code_list.html",
"level": "LEVEL_HIGH",
"line": "8",
"linter": "mypy",
"message": "Missing return statement",
"targetType": "python",
},
],
"lintActions": [
{
"command": "lint",
"fileGroupName": "python",
"linter": "mypy",
"paths": [
"test_data/__init__.py",
],
"verb": "TRUNK_VERB_CHECK",
},
{
"command": "lint",
"fileGroupName": "python",
"linter": "mypy",
"paths": [
"test_data/basic.py",
],
"verb": "TRUNK_VERB_CHECK",
},
{
"command": "lint",
"fileGroupName": "python",
"linter": "mypy",
"paths": [
"test_data/source.py",
],
"verb": "TRUNK_VERB_CHECK",
},
{
"command": "lint",
"fileGroupName": "python",
"linter": "mypy",
"paths": [
"test_data/__init__.py",
],
"upstream": true,
"verb": "TRUNK_VERB_CHECK",
},
{
"command": "lint",
"fileGroupName": "python",
"linter": "mypy",
"paths": [
"test_data/basic.py",
],
"upstream": true,
"verb": "TRUNK_VERB_CHECK",
},
{
"command": "lint",
"fileGroupName": "python",
"linter": "mypy",
"paths": [
"test_data/source.py",
],
"upstream": true,
"verb": "TRUNK_VERB_CHECK",
},
],
"taskFailures": [],
"unformattedFiles": [],
}
`;
Loading