Add shell completion - #222
Merged
Merged
Conversation
thelovekesh
commented
May 21, 2026
Collaborator
- Add shell completion for all commands
- Update install wpm scripts to init shell completion
There was a problem hiding this comment.
Code Review
This pull request implements comprehensive shell completion support for the WPM CLI across Bash, Zsh, Fish, and PowerShell. It introduces a new completion package providing dynamic suggestions for package names, types, and licenses, and updates the installation scripts to automatically configure these completions. Feedback highlights the need to deduplicate package names in the completion logic, a bug in the shell installer's path replacement logic for home-relative directories, and a suggestion to use source instead of exec for refreshing the Zsh environment to avoid session disruption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.