Skip to content

Hardened workflows security #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thelovekesh merged 6 commits into from
May 22, 2026
Merged

Hardened workflows security #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7152d91
Add cooldown period to deps update
thelovekesh May 22, 2026
2e50434
Add `persist-credentials: false` in checkout step
thelovekesh May 22, 2026
bb28769
Update setup go to resolve go version from go.mod
thelovekesh May 22, 2026
22ad138
Remove template evaluation and use env vars
thelovekesh May 22, 2026
eff96d0
Move templates to env var
thelovekesh May 22, 2026
56782d2
Trigger CI
thelovekesh May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ updates:
labels:
- 'go'
- 'dependencies'
cooldown:
default-days: 7
Comment thread
thelovekesh marked this conversation as resolved.

- package-ecosystem: github-actions
directory: '/'
Expand All @@ -21,6 +23,8 @@ updates:
labels:
- 'dependencies'
- 'github-actions'
cooldown:
default-days: 7
Comment thread
thelovekesh marked this conversation as resolved.

- package-ecosystem: github-actions
directory: '.github/actions/build-wpm'
Expand All @@ -34,3 +38,5 @@ updates:
labels:
- 'dependencies'
- 'github-actions'
cooldown:
default-days: 7
Comment thread
thelovekesh marked this conversation as resolved.
45 changes: 34 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,18 @@ jobs:
steps:
- name: checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: determine build platforms
id: platforms
run: |
echo platforms=$(docker buildx bake binary-cross --print | jq -cr '.target."binary-cross".platforms') >> $GITHUB_OUTPUT

- name: print platforms
run: echo ${{ steps.platforms.outputs.platforms }}
run: echo "$PLATFORMS"
env:
PLATFORMS: ${{ steps.platforms.outputs.platforms }}

lint:
runs-on: ubuntu-latest
Expand All @@ -45,11 +49,13 @@ jobs:
steps:
- name: checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: setup go
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0
with:
go-version: '^1.25'
go-version-file: 'go.mod'

- name: check dependencies
run: |
Expand All @@ -71,12 +77,15 @@ jobs:
steps:
- name: checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: set platform pair
id: platform
run: |
platform=${{ matrix.platform }}
echo "pair=${platform//\//-}" >> $GITHUB_OUTPUT
echo "pair=${PLATFORM//\//-}" >> $GITHUB_OUTPUT
env:
PLATFORM: ${{ matrix.platform }}

- name: setup qemu
uses: docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
Expand Down Expand Up @@ -104,8 +113,10 @@ jobs:

- name: s3 upload
if: ${{ github.ref_type == 'branch' && github.actor != 'dependabot[bot]' }}
run: aws s3 cp build/ s3://wpm-cli-builds/${{ github.event.number && github.event.number != null && github.event.number || 'latest' }}/ --exclude "*" --include "wpm-*" --recursive --endpoint-url ${{ secrets.S3_ENDPOINT_URL }} --region auto --checksum-algorithm CRC32
run: aws s3 cp build/ "s3://wpm-cli-builds/${UPLOAD_PATH}/" --exclude "*" --include "wpm-*" --recursive --endpoint-url "$S3_ENDPOINT" --region auto --checksum-algorithm CRC32
env:
S3_ENDPOINT: ${{ secrets.S3_ENDPOINT_URL }}
UPLOAD_PATH: ${{ github.event.number || 'latest' }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

Expand All @@ -131,13 +142,16 @@ jobs:
- name: comment body
id: comment-body
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 #v9.0.0
env:
PR_NUMBER: ${{ github.event.number }}
PLATFORMS: ${{ needs.prepare.outputs.platforms }}
with:
script: |
const platforms = JSON.parse(${{ toJson(needs.prepare.outputs.platforms) }})
const platforms = JSON.parse(process.env.PLATFORMS)
const builds = platforms.map((platform) => {
const platformPair = platform.split('/')
const buildPath = `wpm-${platformPair[0]}-${platformPair[1]}${platformPair[2] ? `-v${platformPair[2]}` : ''}`
const buildUrl = `https://pub-bea4f3d05c4f49e0b54ccf1dad0da103.r2.dev/${{ github.event.number }}/${buildPath}${platformPair[0] === 'windows' ? '.exe' : ''}`
const buildUrl = `https://pub-bea4f3d05c4f49e0b54ccf1dad0da103.r2.dev/${process.env.PR_NUMBER}/${buildPath}${platformPair[0] === 'windows' ? '.exe' : ''}`
const spec = `${platformPair[0]}/${platformPair[1]}${platformPair[2] ? `/${platformPair[2]}` : ''}`
return `- \`${spec}\` - [\`build\`](${buildUrl})`
}).join('\n')
Expand All @@ -146,25 +160,30 @@ jobs:
- name: create comment
if: ${{ steps.find-existing-comment.outputs.result == 'null' }}
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 #v9.0.0
env:
COMMENT_BODY: ${{ steps.comment-body.outputs.result }}
with:
script: |
github.rest.issues.createComment({
repo: context.repo.repo,
owner: context.repo.owner,
issue_number: context.issue.number,
body: ${{ steps.comment-body.outputs.result }},
body: JSON.parse(process.env.COMMENT_BODY),
});

- name: update comment
if: ${{ steps.find-existing-comment.outputs.result != 'null' }}
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 #v9.0.0
env:
COMMENT_ID: ${{ steps.find-existing-comment.outputs.result }}
COMMENT_BODY: ${{ steps.comment-body.outputs.result }}
with:
script: |
github.rest.issues.updateComment({
repo: context.repo.repo,
owner: context.repo.owner,
body: ${{ steps.comment-body.outputs.result }},
comment_id: ${{ steps.find-existing-comment.outputs.result }},
body: JSON.parse(process.env.COMMENT_BODY),
comment_id: JSON.parse(process.env.COMMENT_ID),
});

release:
Expand All @@ -177,6 +196,8 @@ jobs:
steps:
- name: checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: setup qemu
uses: docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
Expand Down Expand Up @@ -236,10 +257,12 @@ jobs:

- name: upload release assets
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 #v9.0.0
env:
UPLOAD_URL: ${{ steps.draft-release.outputs.upload_url }}
with:
script: |
const fs = require('fs');
let uploadUrl = '${{ steps.draft-release.outputs.upload_url }}';
let uploadUrl = process.env.UPLOAD_URL;
const templateMarkerPos = uploadUrl.indexOf("{");
if (templateMarkerPos !== -1) {
uploadUrl = uploadUrl.substring(0, templateMarkerPos);
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 2
persist-credentials: false

- name: setup go
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0
Expand Down