fix: clip edge plated holes flush with board boundary - #979
Open
KrishnaX12 wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KrishnaX12
force-pushed
the
fix/plated-hole-edge-clipping
branch
from
August 17, 2026 12:19
be5db29 to
4cc277d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes plated through-holes at the board edge extending beyond the board outline because of an artificial clipping outset.
BOARD_CLIP_XY_OUTSETto0, so clipping follows the exact board outline.BOARD_CLIP_XY_OUTSETto0, so clipping follows the exact board outline.Bugs / Plated Hole Edge Cutout / Edge and Corner Plated Holesto cover all four edges, a corner, and an interior reference hole.Verification
bun run build-storybookbunx tsc --noEmitThe fixture can be inspected in Storybook with either rendering engine; the edge and corner annular rings should end flush with the board boundary.