Skip to content

fix: clip edge plated holes flush with board boundary - #979

Open
KrishnaX12 wants to merge 3 commits into
tscircuit:mainfrom
KrishnaX12:fix/plated-hole-edge-clipping
Open

fix: clip edge plated holes flush with board boundary#979
KrishnaX12 wants to merge 3 commits into
tscircuit:mainfrom
KrishnaX12:fix/plated-hole-edge-clipping

Conversation

@KrishnaX12

@KrishnaX12 KrishnaX12 commented Aug 17, 2026

Copy link
Copy Markdown

Summary of Changes

Fixes plated through-holes at the board edge extending beyond the board outline because of an artificial clipping outset.

  1. JSCAD: sets BOARD_CLIP_XY_OUTSET to 0, so clipping follows the exact board outline.
  2. Manifold: sets BOARD_CLIP_XY_OUTSET to 0, so clipping follows the exact board outline.
  3. Visual regression fixture: expands Bugs / Plated Hole Edge Cutout / Edge and Corner Plated Holes to cover all four edges, a corner, and an interior reference hole.

Verification

  • bun run build-storybook
  • bunx tsc --noEmit

The fixture can be inspected in Storybook with either rendering engine; the edge and corner annular rings should end flush with the board boundary.

@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview Aug 18, 2026 5:40pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant