Skip to content

Conversation

@rushabhcodes
Copy link

This pull request adds support for exporting a new "schematic simulation SVG" format in the exportSnippet utility. The changes ensure this new format is properly integrated into the export workflow, including file extension handling and allowed formats.

Support for new export format:

  • Added convertCircuitJsonToSchematicSimulationSvg import and integrated it into the export logic in exportSnippet, enabling conversion of circuit JSON to schematic simulation SVGs. [1] [2]
  • Included "schematic-simulation-svg" in the ALLOWED_EXPORT_FORMATS array to allow this format as an export option.
  • Updated the OUTPUT_EXTENSIONS mapping to provide the correct file extension for the new format (-schematic-simulation.svg).

/fix #1502

Copilot AI review requested due to automatic review settings December 30, 2025 18:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for exporting schematic simulation SVGs, a new export format that enables visualization of schematics with simulation capabilities. The implementation follows existing patterns and integrates seamlessly with the export workflow.

Key changes:

  • Imported convertCircuitJsonToSchematicSimulationSvg from the circuit-to-svg library
  • Added "schematic-simulation-svg" to the allowed export formats list
  • Configured the appropriate file extension mapping (-schematic-simulation.svg)
  • Implemented the conversion logic in the export switch statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ShiboSoftwareDev
Copy link
Contributor

you need to setup the simulation engine, we currently use two engines, one is called spicey which is the default, the other is called ngspice which is more mature. you can see how they're setup in core

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions bot closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce a command to create an analog simulation svg

2 participants