Skip to content

Avoid schematic junctions between different nets - #2878

Merged
imrishabh18 merged 1 commit into
mainfrom
agent/fix-cross-net-junctions
Jul 25, 2026
Merged

Avoid schematic junctions between different nets#2878
imrishabh18 merged 1 commit into
mainfrom
agent/fix-cross-net-junctions

Conversation

@imrishabh18

Copy link
Copy Markdown
Member

Summary

  • require matching connectivity keys for every schematic junction case, including endpoint-to-endpoint and endpoint-to-interior contacts
  • add a focused CC2/GND regression plus a same-net control
  • update the linked RP2040 schematic snapshot to remove the false junction dots

Root cause

computeJunctions checked isSameNet for middle-to-middle intersections, but its endpoint-contact branches ran for every trace pair. When the generated CC2 connector overlapped/touched the GND traces, those branches added junctions to both traces and made R9 appear grounded at both ends.

This renderer-side correction complements tscircuit/schematic-trace-solver#727, which prevents the generated CC2 connector from overlapping the GND rail in the first place. The two fixes address independent failure modes and can be reviewed separately.

Validation

  • bunx tsc --noEmit
  • bun test tests/utils/schematic/compute-junctions.test.ts
  • related junction repro suite: 16 passed
  • bun test tests/components/primitive-components/schematic-section-rp2040-autolayout.test.tsx

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Jul 25, 2026 10:59pm

Request Review

@imrishabh18
imrishabh18 marked this pull request as ready for review July 25, 2026 23:13
@imrishabh18
imrishabh18 merged commit db68b78 into main Jul 25, 2026
11 checks passed
@imrishabh18
imrishabh18 deleted the agent/fix-cross-net-junctions branch July 25, 2026 23:28
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants