Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-cache-versionalongside the existing cache diagnosticsRoot cause
The Worker marked query results fresh for 14 days and sent the same two-week
max-ageto browsers. A deployed route or filtering change could therefore be hidden by both browser caching and an older KV response. The existingcachebust=1escape hatch worked, but users should not need it after every deployment.Live verification before this patch
The merged photodiode band filters are working in production:
The live response returned nine 420 nm-peak devices, excluded the 700–1100 nm peak band, and reported
x-cache: MISS; the same query withcachebust=1reportedx-cache: BUST. Production also confirmed the problematic two-week cache-control header.Validation
bun test— 184 passedbunx tsc --noEmitbunx tsc --noEmit --project cf-proxy/tsconfig.jsonbun run format:checkbunx wrangler deploy --dry-run --outdir /tmp/jlcsearch-cache-dry-run— version metadata binding recognized