Conversation
mohan-bee
marked this pull request as draft
August 11, 2026 08:53
mohan-bee
force-pushed
the
expose-source-assembly-fields
branch
from
August 11, 2026 09:10
8e7a2fe to
d29cdc8
Compare
mohan-bee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
component search should return the same pcba eligibility label shown by jlcpcb instead of inferring service support from basic-part status.
before
jlcpcb componentProductType was discarded upstream, so search results could not distinguish economic and standard, economic only, and standard only eligibility.
after
the source-backed numeric discriminator from yaqwsx/jlcparts#160 is preserved through catalog and search-index rebuilds, then serialized as pcba_type with all three exact jlcpcb labels; focused tests cover values 0, 1, 2, unknown values, and null compatibility.