Add Show Warnings toggle to schematic context menu - #272
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Show Warnings checkbox to the schematic right-click menu. Warnings start hidden; toggling the item immediately shows or hides yellow warning outlines and text callouts from the supplied circuit JSON. The menu stays open and supports mouse and keyboard activation.
Passes the toggle state to
shouldDrawWarningsand updatescircuit-to-svgto^0.0.416, which includes the schematic warning renderer.Validation: all 28 tests pass, including an integration test that opens the viewer context menu and shows/hides rendered warnings with mouse and keyboard. Type checking, build, formatting, and
git diff --checkpass.