Fedora related and other trivial improvements #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It compiles even without this fix because of `pkg-config --cflags sdl2`, but C/C++ plugin of VS Code shows an error otherwise.
$ make
mkdir -pv build
mkdir: created directory 'build'
cc -Wall -Wextra -ggdb -std=c99 -pedantic -Ithirdparty -Ibuild -DPENGER -o build/png2c src/png2c.c -lm
./build/png2c ./assets/digits.png digits > build/digits.h
./build/png2c ./assets/penger_walk_sheet.png penger > build/penger_walk_sheet.h
cc `pkg-config --cflags sdl2` -Wall -Wextra -ggdb -std=c99 -pedantic -Ithirdparty -Ibuild -DPENGER -o sowon src/main.c `pkg-config --libs sdl2` -lm
In file included from src/main.c:10:
src/common.c:16:9: warning: ‘CHAR_WIDTH’ redefined
16 | #define CHAR_WIDTH (300 / 2)
| ^~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-redhat-linux/15/include/limits.h:210,
from /usr/lib/gcc/x86_64-redhat-linux/15/include/syslimits.h:9,
from /usr/lib/gcc/x86_64-redhat-linux/15/include/limits.h:34,
from /usr/include/SDL2/SDL_config_unix.h:28,
from /usr/include/SDL2/SDL_config-x86_64.h:51,
from /usr/include/SDL2/SDL_config.h:58,
from /usr/include/SDL2/SDL_stdinc.h:33,
from /usr/include/SDL2/SDL_main.h:25,
from /usr/include/SDL2/SDL.h:31,
from src/main.c:8:
/usr/include/limits.h:147:11: note: this is the location of the previous definition
147 | # define CHAR_WIDTH 8
| ^~~~~~~~~~
cc -Wall -Wextra -ggdb -std=c99 -pedantic -Ithirdparty -Ibuild -DPENGER -o sowon_rgfw src/main_rgfw.c -lX11 -lXrandr -lGLX -lGL -lm
gzip -c docs/sowon.6 > docs/sowon.6.gz
Read 5.1.2.2.1 Program startup https://www.dii.uchile.cl/~daespino/files/Iso_C_1999_definition.pdf
rexim
added a commit
that referenced
this pull request
Dec 3, 2025
Co-authored-by: Rostislav Krasny <[email protected]>
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done on Fedora 43 with the Cinnamon Desktop Environment and all latest updates.