Fix/release publish#21
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation file, Docs/RELEASE_WORKFLOW.md, which outlines the automated release and WinGet update workflow. The feedback identifies several instances where the PowerShell script parameter -NewVersion is used incorrectly in the examples and should be replaced with -Version to match the actual script implementation.
| ## Alur Otomatis | ||
|
|
||
| ``` | ||
| 1. User jalankan: .\Scripts\release-version.ps1 -NewVersion X.X.X |
There was a problem hiding this comment.
The parameter name in Scripts/release-version.ps1 is -Version, not -NewVersion. Using -NewVersion will cause the script to fail as the parameter does not exist.
Suggested change
| 1. User jalankan: .\Scripts\release-version.ps1 -NewVersion X.X.X | |
| 1. User jalankan: .\Scripts\release-version.ps1 -Version X.X.X |
|
|
||
| Dry-run dulu: | ||
| ```powershell | ||
| .\Scripts\release-version.ps1 -NewVersion X.X.X -DryRun |
|
|
||
| Kalo OK, jalankan beneran: | ||
| ```powershell | ||
| .\Scripts\release-version.ps1 -NewVersion X.X.X |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.