Split raw_results.columns into columns_with_internal_p_ids / columns_with_original_p_ids#131
Merged
Merged
Conversation
…mapped_ids `raw_results.columns` is computable from `processed_data` alone again (without any `input_data`), restoring the pre-#108 pruning behavior for callers that bypass input processing. The reverse-translation of endogenous `p_id_*` columns introduced in #108 moves to the new node `raw_results.columns_with_remapped_ids`, which `results.tree` consumes, so all `results.*` outputs keep returning user-space `p_id` values. Closes #130. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…original_p_ids Drop the plain `raw_results.columns` name. Both nodes now state their id-space explicitly; "original" matches the existing internal vocabulary (sorted_orig_p_ids, _translate_internal_to_orig_p_ids). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MImmesberger
changed the title
Build dummy processed_data from the partialled function's free arguments and annotations, exactly like the jittability test that broke originally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the is_interface_function assertions (they test the decorator, not the code) and collapse the three columns_with_original_p_ids behavior tests into one — each behavior is already covered end-to-end in test_endogenous_p_id_targets.py; the single unit test remains as a fast failure localizer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…m functions Port the downstream jittability test: parametrize over every mettsim column function, build dummy processed_data from its free arguments, and target raw_results.columns_with_internal_p_ids with a pre-built specialized environment and no input_data. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…end-to-end Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
It runs on the JAX backend only; the coverage job uses the NumPy backend, under which all of its cases are skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…m into fix-130-remapped-ids-node
hmgaudecker
approved these changes
Jun 7, 2026
MImmesberger
added a commit
to ttsim-dev/gettsim
that referenced
this pull request
Jun 7, 2026
…th_internal_p_ids (#1196) See ttsim-dev/ttsim#131 --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130.
raw_results.columnsintoraw_results.columns_with_internal_p_ids(computable fromprocessed_dataalone, endogenousp_id_*columns hold internal indices) andraw_results.columns_with_original_p_ids(the reverse-translation from Reverse-translate endogenous p_id_* targets to user p_ids (closes #43) #108, consumed byresults.tree, so allresults.*outputs keep returning user-spacep_ids).MainTargetand theRawResultsmain arg.src_mettsim/tests_middle_earth/test_jittability.pyexercises theprocessed_data-only path over all mettsim column functions.raw_results.columnsno longer exists; downstream switches tocolumns_with_internal_p_ids(Adapt test_jittability to renamed ttsim target raw_results.columns_with_internal_p_ids gettsim#1196).🤖 Generated with Claude Code