windows support#1
Merged
Merged
Conversation
Leverages the C std version and the standard __STDC_NO_VLA__ macro to detect whether VLA is supported, and if not falls back to using alloca.
The MSVC compiler only exposes M_PI if _USE_MATH_DEFINES is defined... don't ask me why.
mcasper
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains 2 commits, the first one adds support for non-vla compilers (like MSVC), upstream change is here: xiph/rnnoise#219
Second commit updates our CMakeLists.txt file to add the
_USE_MATH_DEFINESto expose theM_PIdefinition on MSVC. This change can't be upstreamed since upstream doesn't use CMAKE. We could try to define_USE_MATH_DEFINESin the source code, but it's less brittle to do it in the build system since doing it in source would require enforcing that it gets defined beforemath.hwhich is difficult to guarantee.I tested that this still builds on linux and it should theortically have no affect. Would like to double check that this also has no affect on macOS...by testing that the C macro is taking the proper codepath.