feat: Add azure_security_center_assessment table - #992
Conversation
|
Hi @dark-panda , thanks for opening this PR! I had a look through the changes and had a few suggestions/questions:
I also noticed there were other changes in the |
azure_securicy_center_assessment tableazure_security_center_assessment table
|
@cbruno10 uh yeah, clearly missed the debugging statements, I have some branches kicking around here and need to get my local copy in order. Fixes incoming. |
3711d5f to
e90449a
Compare
|
Hi @dark-panda , just checking, is this PR ready for review again? Thanks! |
e90449a to
238cbcf
Compare
|
@cbruno10 just pushed a few version after rebasing, should be good(er) to go. |
cbruno10
left a comment
There was a problem hiding this comment.
@dark-panda Thanks for making the suggested changes a few weeks ago! I've added a couple more based on those updates. Can you please also add a table doc for the new table with some examples, and then share the query results from those examples in the PR body? Thanks!
eb9fd8c to
52c671e
Compare
cbruno10
left a comment
There was a problem hiding this comment.
@dark-panda Thanks for making the review changes! I've added a few more suggestions and replies to older suggestions. Can you please also fix the linting error? Thanks!
9058b5e to
5a93789
Compare
|
G'day all. I saw there was a version bump in the Steampipe SDKs so I bumped those and pushed again. Hopefully we're looking good now? |
5a93789 to
0cee2e8
Compare
This PR adds a new table for Security Center assessments which can be used to pull down compliance information for a number of compliance frameworks. An associated PCI DSS v4.0.1 benchmark uses this table to perform some of its checks.