Skip to content

feat: Add azure_security_center_assessment table - #992

Open
dark-panda wants to merge 1 commit into
turbot:mainfrom
dark-panda:feature/add-securicy-center-assessment-table
Open

feat: Add azure_security_center_assessment table#992
dark-panda wants to merge 1 commit into
turbot:mainfrom
dark-panda:feature/add-securicy-center-assessment-table

Conversation

@dark-panda

Copy link
Copy Markdown

This PR adds a new table for Security Center assessments which can be used to pull down compliance information for a number of compliance frameworks. An associated PCI DSS v4.0.1 benchmark uses this table to perform some of its checks.

@cbruno10

cbruno10 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Hi @dark-panda , thanks for opening this PR!

I had a look through the changes and had a few suggestions/questions:

  • I noticed there are a few debug statements, like HELLO WORLD, can you please remove any leftover statements?
  • I think the fmt import is also only used for debug statements, so that can be removed afterward.
  • Errors are being swallowed since the code is return err, nil instead of return nil, err. I think this bug is also in other tables, but we can start by fixing it in this table and then we'll fix the others after.
  • Minor, note, but can you please ensure the entry in plugin.go is sorted alphabetically.

I also noticed there were other changes in the azure_batch_account table, were these intentionally included?

@cbruno10 cbruno10 changed the title feat: Add azure_securicy_center_assessment table feat: Add azure_security_center_assessment table Jun 1, 2026
@dark-panda

Copy link
Copy Markdown
Author

@cbruno10 uh yeah, clearly missed the debugging statements, I have some branches kicking around here and need to get my local copy in order. Fixes incoming.

@dark-panda
dark-panda force-pushed the feature/add-securicy-center-assessment-table branch from 3711d5f to e90449a Compare June 1, 2026 16:18
@cbruno10

Copy link
Copy Markdown
Contributor

Hi @dark-panda , just checking, is this PR ready for review again? Thanks!

@dark-panda
dark-panda force-pushed the feature/add-securicy-center-assessment-table branch from e90449a to 238cbcf Compare June 22, 2026 13:23
@dark-panda

Copy link
Copy Markdown
Author

@cbruno10 just pushed a few version after rebasing, should be good(er) to go.

@cbruno10 cbruno10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dark-panda Thanks for making the suggested changes a few weeks ago! I've added a couple more based on those updates. Can you please also add a table doc for the new table with some examples, and then share the query results from those examples in the PR body? Thanks!

Comment thread azure/table_azure_batch_account.go Outdated
Comment thread azure/table_azure_batch_account.go Outdated
Comment thread azure/table_azure_security_center_assessment.go Outdated
Comment thread azure/table_azure_security_center_assessment.go
Comment thread azure/table_azure_security_center_assessment.go Outdated
Comment thread azure/table_azure_security_center_assessment.go
Comment thread azure/table_azure_security_center_assessment.go Outdated
Comment thread azure/table_azure_security_center_assessment.go
@dark-panda
dark-panda force-pushed the feature/add-securicy-center-assessment-table branch 2 times, most recently from eb9fd8c to 52c671e Compare July 21, 2026 14:25
@dark-panda
dark-panda requested a review from cbruno10 July 21, 2026 19:53

@cbruno10 cbruno10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dark-panda Thanks for making the review changes! I've added a few more suggestions and replies to older suggestions. Can you please also fix the linting error? Thanks!

Comment thread azure/table_azure_security_center_assessment.go Outdated
Comment thread azure/table_azure_security_center_assessment.go
Comment thread azure/table_azure_security_center_assessment.go Outdated
Comment thread azure/table_azure_security_center_assessment.go Outdated
Comment thread azure/table_azure_security_center_assessment.go
Comment thread azure/table_azure_security_center_assessment.go Outdated
@dark-panda
dark-panda force-pushed the feature/add-securicy-center-assessment-table branch 2 times, most recently from 9058b5e to 5a93789 Compare August 4, 2026 18:53
@dark-panda

Copy link
Copy Markdown
Author

G'day all. I saw there was a version bump in the Steampipe SDKs so I bumped those and pushed again. Hopefully we're looking good now?

@dark-panda
dark-panda force-pushed the feature/add-securicy-center-assessment-table branch from 5a93789 to 0cee2e8 Compare August 17, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants